From cd3589487ed2e3956e8b688dda0850ceeb1afe9d Mon Sep 17 00:00:00 2001 From: Jordan Hunt Date: Wed, 2 Jun 2021 10:34:07 +0200 Subject: [PATCH 1/4] remove maxWidth from Dropdown --- styles/native/ts/core/widgets/dropdown.ts | 1 - styles/native/ts/core/widgets/referenceselector.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/styles/native/ts/core/widgets/dropdown.ts b/styles/native/ts/core/widgets/dropdown.ts index a75747b1..a4e61285 100644 --- a/styles/native/ts/core/widgets/dropdown.ts +++ b/styles/native/ts/core/widgets/dropdown.ts @@ -79,7 +79,6 @@ export const DropDown: DropDownType = { }, itemContainer: { // All ViewStyle properties & rippleColor & activeOpacity & underlayColor are allowed - maxWidth: 500, paddingVertical: 6, paddingHorizontal: 16, backgroundColor: input.backgroundColor, diff --git a/styles/native/ts/core/widgets/referenceselector.ts b/styles/native/ts/core/widgets/referenceselector.ts index 178b21ef..ea2dcfe7 100644 --- a/styles/native/ts/core/widgets/referenceselector.ts +++ b/styles/native/ts/core/widgets/referenceselector.ts @@ -81,7 +81,6 @@ export const ReferenceSelector: DropDownType = { }, itemContainer: { // All ViewStyle properties & rippleColor & activeOpacity & underlayColor are allowed - maxWidth: 500, paddingVertical: 6, paddingHorizontal: 16, backgroundColor: input.backgroundColor, From bf01d69f4ff87d6f999a2be378a34b9e0a7a948e Mon Sep 17 00:00:00 2001 From: Jordan Hunt Date: Thu, 3 Jun 2021 09:41:32 +0200 Subject: [PATCH 2/4] add width and unset maxWidth for client < 8.18.7 --- styles/native/ts/core/widgets/dropdown.ts | 4 ++++ styles/native/ts/core/widgets/referenceselector.ts | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/styles/native/ts/core/widgets/dropdown.ts b/styles/native/ts/core/widgets/dropdown.ts index a4e61285..b410bb63 100644 --- a/styles/native/ts/core/widgets/dropdown.ts +++ b/styles/native/ts/core/widgets/dropdown.ts @@ -79,6 +79,8 @@ export const DropDown: DropDownType = { }, itemContainer: { // All ViewStyle properties & rippleColor & activeOpacity & underlayColor are allowed + width: "100%", + maxWidth: undefined, // unset core widget's default maxWidth value (prior to 8.18.7) paddingVertical: 6, paddingHorizontal: 16, backgroundColor: input.backgroundColor, @@ -98,6 +100,8 @@ export const DropDown: DropDownType = { }, selectedItemContainer: { // All ViewStyle properties are allowed + width: "100%", + maxWidth: undefined, // unset core widget's default maxWidth value (prior to 8.18.7) backgroundColor: contrast.lowest, }, /* New dropdown styles end */ diff --git a/styles/native/ts/core/widgets/referenceselector.ts b/styles/native/ts/core/widgets/referenceselector.ts index ea2dcfe7..322bf7fe 100644 --- a/styles/native/ts/core/widgets/referenceselector.ts +++ b/styles/native/ts/core/widgets/referenceselector.ts @@ -81,6 +81,8 @@ export const ReferenceSelector: DropDownType = { }, itemContainer: { // All ViewStyle properties & rippleColor & activeOpacity & underlayColor are allowed + width: "100%", + maxWidth: undefined, // unset core widget's default maxWidth value (prior to 8.18.7) paddingVertical: 6, paddingHorizontal: 16, backgroundColor: input.backgroundColor, @@ -100,6 +102,8 @@ export const ReferenceSelector: DropDownType = { }, selectedItemContainer: { // All ViewStyle properties are allowed + width: "100%", + maxWidth: undefined, // unset core widget's default maxWidth value (prior to 8.18.7) backgroundColor: contrast.lowest, }, /* New dropdown styles end */ From 855bc5a06dc4bf09e729f151396517639add17c5 Mon Sep 17 00:00:00 2001 From: Jordan Hunt Date: Mon, 5 Jul 2021 13:19:03 +0200 Subject: [PATCH 3/4] update lock file --- package-lock.json | 44 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index c51fdd4a..9878d34b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,5 +1,45 @@ { "name": "atlas-ui-framework", - "version": "2.5.3", - "lockfileVersion": 1 + "version": "2.7.2", + "lockfileVersion": 1, + "requires": true, + "dependencies": { + "@types/prop-types": { + "version": "15.7.3", + "resolved": "https://registry.npmjs.org/@types/prop-types/-/prop-types-15.7.3.tgz", + "integrity": "sha512-KfRL3PuHmqQLOG+2tGpRO26Ctg+Cq1E01D2DMriKEATHgWLfeNDmq9e29Q9WIky0dQ3NPkd1mzYH8Lm936Z9qw==", + "dev": true + }, + "@types/react": { + "version": "16.9.50", + "resolved": "https://registry.npmjs.org/@types/react/-/react-16.9.50.tgz", + "integrity": "sha512-kPx5YsNnKDJejTk1P+lqThwxN2PczrocwsvqXnjvVvKpFescoY62ZiM3TV7dH1T8lFhlHZF+PE5xUyimUwqEGA==", + "dev": true, + "requires": { + "@types/prop-types": "*", + "csstype": "^3.0.2" + } + }, + "@types/react-native": { + "version": "0.61.23", + "resolved": "https://registry.npmjs.org/@types/react-native/-/react-native-0.61.23.tgz", + "integrity": "sha512-upHmySsrVBDBokWWhYIKkKnpvadsHdioSjbBTu4xl7fjN0yb94KR5ngUOBXsyqAYqQzF+hP6qpvobG9M7Jr6hw==", + "dev": true, + "requires": { + "@types/react": "*" + } + }, + "csstype": { + "version": "3.0.3", + "resolved": "https://registry.npmjs.org/csstype/-/csstype-3.0.3.tgz", + "integrity": "sha512-jPl+wbWPOWJ7SXsWyqGRk3lGecbar0Cb0OvZF/r/ZU011R4YqiRehgkQ9p4eQfo9DSDLqLL3wHwfxeJiuIsNag==", + "dev": true + }, + "react-native-device-info": { + "version": "5.6.5", + "resolved": "https://registry.npmjs.org/react-native-device-info/-/react-native-device-info-5.6.5.tgz", + "integrity": "sha512-l457wv7gYXSRnm38AH+NpCgKYa1zxxfN0EL8mTBxo+TnasXtk0FZ86zWDLhm4eqpcSH8xpT/+z2MQrATfqCaoA==", + "dev": true + } + } } From dceb36017aa8ff69666144084acfd3659dbd913f Mon Sep 17 00:00:00 2001 From: Jordan Hunt Date: Mon, 5 Jul 2021 13:19:21 +0200 Subject: [PATCH 4/4] bump patch --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 3ec8faf3..8f6cb7d9 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "atlas-ui-framework", - "version": "2.7.1", + "version": "2.7.2", "description": "Mendix Atlas UI is the foundation of making beautiful apps with Mendix. For more information about the framework go to https://atlas.mendix.com.", "main": "", "scripts": {