Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support test cases from the new SDK test suite #3

Open
aaronsteers opened this issue Dec 5, 2022 · 0 comments
Open

Support test cases from the new SDK test suite #3

aaronsteers opened this issue Dec 5, 2022 · 0 comments

Comments

@aaronsteers
Copy link

Would be awesome if we could send all "expect-to-succeed" tests from here:

Since this tap normally expects JSONL inputs, this probably would require that we have some sort of "replay" or "passthrough mode" where we just echo the .singer.json messages from a source file and not add any other Singer messages ourselves.

In terms of delivery, we could accept a pre-written config.json file that would contain a mapping to all the tests (with http refs declared as remote references to the SDK repo), and this would be helpful when the user then wanted to limit the tests. (For instance, if they know one is failing but they want to check with all but that one.)

Another way to deliver would be to have a top-level include_standard_tests = true config option that would have the same effect as the above while being easier to set. Perhaps better though, it to allow the --config option for this tap to come from an http reference. That would allow users simplicity of a one-liner execution tap-smoke-test --config=https://raw.githubusercontent.com/meltano/tap-smoke-test/main/demo-data/looping-stream-config.json. And to customize, they could download the file and change whatever they wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant