-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make SQLConnector _connect function public #2262
Comments
Thanks @visch! I think the "private" It hints that something should be implemented in Note this was introduced in #1394 to ensure there's a single entry point for handling the connection object: #1393. |
I'm probably missing something @edgarrmondragon
The SDK does it too. What triggered this for me is the linter told me I should so I added the code below. It just seemed weird to have to lint for the "standard" use case We can just close and I can ignore it 🤷 , it's me being too pedantic |
No worries. We might end up doing this anyway if #1649 is shipped, or at least its Connector interface definition. |
Feature scope
Taps (catalog, state, stream maps, tests, etc.)
Description
The function here
sdk/singer_sdk/connectors/sql.py
Lines 82 to 85 in 0285704
I'd like to change to the name
connect
as we use this in different taps.See
The text was updated successfully, but these errors were encountered: