Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

feat: Handling of "inf" and similar NaN values #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edgarrmondragon opened this issue Feb 2, 2024 · 1 comment
Closed

feat: Handling of "inf" and similar NaN values #2211

edgarrmondragon opened this issue Feb 2, 2024 · 1 comment
Labels
help wanted Extra attention is needed kind/Feature New feature or request needs refinement valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Feb 2, 2024

Feature scope

Taps (catalog, state, stream maps, tests, etc.)

Description

For example, the Postgres NUMERIC type supports the following:

In addition to ordinary numeric values, the numeric type has several special values:


Infinity
-Infinity
NaN

Python clients usually represent those as math.inf, -math.inf and math.nan respectively. However, for interoperability reasons these NaN values are not supported in JSON or JSON Schema.

Currently, they cause the tap to crash if present, during serialization. This library uses simplejson, so the ignore_nan parameter is available to make the values null but it's unclear whether this silent data loss behavior is preferable to crashing.

Copy link

stale bot commented Feb 1, 2025

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Feb 1, 2025
@edgarrmondragon edgarrmondragon pinned this issue Feb 6, 2025
@edgarrmondragon edgarrmondragon unpinned this issue Feb 6, 2025
@stale stale bot removed the stale label Feb 6, 2025
@meltano meltano locked and limited conversation to collaborators Feb 6, 2025
@edgarrmondragon edgarrmondragon converted this issue into discussion #2873 Feb 6, 2025

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
help wanted Extra attention is needed kind/Feature New feature or request needs refinement valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant