Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add rollback support for overwrite load method #1956

Closed
pnadolny13 opened this issue Sep 13, 2023 · 1 comment
Closed

feat: Add rollback support for overwrite load method #1956

pnadolny13 opened this issue Sep 13, 2023 · 1 comment
Labels
stale

Comments

@pnadolny13
Copy link
Contributor

Originally driven by #1783 which was closed by #1893 but doesnt have safe backup/rollback support for the overwrite method.

The current status of this is described in #1893 (comment) and a draft PR is in #1941.

The overwrite load method currently drops the table before attempting to load so if the sync fails then the user is left with an empty table (or no table if recreate fails). This issue is to create a workflow to:

  • alter existing table to back it up instead of dropping it
  • attempt to recreate the table and load the new data
  • if success, delete the back up table
  • if failed, delete the new table and rename the backup table to the original name
@pnadolny13 pnadolny13 mentioned this issue Sep 13, 2023
Closed
@stale Stale
Copy link

stale bot commented Sep 12, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Sep 12, 2024
@stale stale bot closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: backup/rollback instead of dropping in override mode meltano/sdk
1 participant
@pnadolny13