Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break: Support the same env var formats as Meltano #1896

Closed
edgarrmondragon opened this issue Aug 4, 2023 · 2 comments · Fixed by #2637
Closed

break: Support the same env var formats as Meltano #1896

edgarrmondragon opened this issue Aug 4, 2023 · 2 comments · Fixed by #2637

Comments

@edgarrmondragon
Copy link
Collaborator

Currently, a setting of array type can be parsed from an env var with the following format:

MY_ENV_VAR='a,b,c'

However, Meltano expects array settings to be JSON arrays:

MY_ENV_VAR='["a","b","c"]'

This mismatch is surprising to users familiar with Meltano, and to developers using Meltano to test connectors during development. In the latter case, the env vars and .env file are incompatible.

Related:

@edgarrmondragon
Copy link
Collaborator Author

We could do this in a non-breaking way by adding a flag that's present in the cookiecutter templates so new packages support the new format

Copy link

stale bot commented Aug 9, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant