Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Some SDK settings are miscategorised #1781

Open
ReubenFrankel opened this issue Jun 13, 2024 · 0 comments
Open

🐛 BUG: Some SDK settings are miscategorised #1781

ReubenFrankel opened this issue Jun 13, 2024 · 0 comments
Assignees

Comments

@ReubenFrankel
Copy link
Contributor

ReubenFrankel commented Jun 13, 2024

Not sure of all that are missing from the Hub list of SDK setttings, but for example: batch_size_rows is listed as a plugin-specific setting for target-postgres, despite it not being explicitly defined in its config schema.

Side note: this target does explicitly define activate_version, which is also an SDK setting (and also missing from the Hub list), but I think the logic is correct here - i.e. if a plugin built with the SDK redefines an SDK setting (by name), then always treat it as a plugin-specific setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants