Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Variant metrics are namespaced by repo and airbyte-wrapper shares repo #1113

Closed
pnadolny13 opened this issue Jan 4, 2023 · 2 comments
Assignees

Comments

@pnadolny13
Copy link
Contributor

pnadolny13 commented Jan 4, 2023

The variant metrics are currently namespaced by repo name because up until now the repo was uniquely 1-1 with a tap. With tap-airbyte-wrapper many plugins share the same repo name so current state will likely lump all usage into one metric thats shared across all airbyte variants.

An example is

https://github.com/MeltanoLabs/tap-github:
.

Potential Solution:

  • It might be better to namespace metrics based on {plugin_type}-{plugin_name}-{plugin_variant} like we do in most other places.
  • This would require an update to Squared pipelines that produce the data prior to working
  • squared related link Hub metrics namespaced by repo fails squared#514
@tayloramurphy
Copy link
Collaborator

@pnadolny13 good catch on this!

@pnadolny13
Copy link
Contributor Author

I think this was resolved naturally once we set the repo name to reference the subdirectory in the airbyte repo like https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-adjust and it flowed through Squared. I see plugin pages with different metrics:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

2 participants