Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to PyPI #70

Closed
6 tasks done
edgarrmondragon opened this issue Jul 31, 2024 · 6 comments
Closed
6 tasks done

Publish to PyPI #70

edgarrmondragon opened this issue Jul 31, 2024 · 6 comments
Assignees

Comments

@edgarrmondragon
Copy link
Contributor

edgarrmondragon commented Jul 31, 2024

Tasks

@edgarrmondragon edgarrmondragon self-assigned this Jul 31, 2024
@edgarrmondragon
Copy link
Contributor Author

First part is done:

Screenshot 2024-07-31 at 5 51 29 p m

(excuse the Spanglish UI)

@edgarrmondragon
Copy link
Contributor Author

Screenshot 2024-07-31 at 5 54 33 p m

@edgarrmondragon
Copy link
Contributor Author

PyPI doesn't like our package name:

* `invalid-payload`: The name 'dbt-ext' is too similar to an existing project. See https://pypi.org/help/#project-name for more information.

https://github.com/meltano/dbt-ext/actions/runs/10201267503/job/28222731657

It probably thinks we're trying to typo-squat some other dbt-related package 😅.

Opinions on renaming the package meltano-dbt-ext? The repo would keep the same name, so git refs in any pip_url would continue working, but when we switch them to use the package name it'd be meltano-dbt-ext instead of dbt-ext.

We could also open an issue in https://github.com/pypi/support, but that seems to be too slow of a process and I don't think we're married to dbt-ext as the PyPI package name.

Thoughts @meltano/engineering?

@WillDaSilva
Copy link
Member

That's mildly frustrating, but also a natural consequence of there being a shared global namespace on PyPI.

I support renaming the package to meltano-dbt-ext. Normally for something like this I'd recommend a major version bump just to be safe, but in this case we're still using version 0 as the major version, wherein breaking changes are permitted, so it doesn't really matter.

@edgarrmondragon
Copy link
Contributor Author

PR to rename the package: #73

@edgarrmondragon
Copy link
Contributor Author

All done here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants