Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations are duplicated when undecorating a tracked nonterminal tree #721

Open
krame505 opened this issue Oct 19, 2022 · 0 comments
Open
Labels

Comments

@krame505
Copy link
Member

Something I don't understand in the origin tracking implementation: when a tracked tree gets explicitly undecorated with new, we deep-copy the children in order to set their origins info to indicate that they were also undecorated by new. But for some reason we are also deep-copying and updating the origin of annotations (any that are tracked nonterminals, at least) even though they are not undecorated when the tree is undecorated.

This also seems to be inconsistent with the origin tracking paper, which only mentions children being duplicated. So I am I right in thinking that this is a bug, or was there some implementation reason for this that I'm not aware of?

In practice I don't think this is exercised anywhere, since having a tracked nonterminal as an annotation on another tracked nonterminal is kind of a weird thing to do.

@github-project-automation github-project-automation bot moved this to To do - uncategorized in Hackathon Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

No branches or pull requests

2 participants