Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated files from deleted grammars persist even with --clean #675

Open
krame505 opened this issue Jul 9, 2022 · 1 comment
Open

Generated files from deleted grammars persist even with --clean #675

krame505 opened this issue Jul 9, 2022 · 1 comment
Labels

Comments

@krame505
Copy link
Member

krame505 commented Jul 9, 2022

Currently, when generating translation we only delete existing generated files from the directories corresponding to grammars that are being built; however files from grammars that no longer exist can persist and be seen by ant, causing java compilation problems. --clean currently works by treating every interface file as out of date, and just re-translates every grammar dependency, so this still happens even with a clean build.

I suppose we could have --clean just blow away the contents of the whole generated directory. This would also delete existing generated parsers, but that seems like reasonable behavior for a clean build. (Currently I think parsers don't get regenerated with --clean if the copper spec doesn't change? Which might cause unexpected behavior when experimenting with changes to Copper.)

@krame505
Copy link
Member Author

krame505 commented Jul 9, 2022

I guess just nuking the generated directory with --clean doesn't really fully solve the problem, since we would then have another instance of "build fails without --clean". We also don't want to delete generated files from grammars that just aren't triggered in the current build.

Maybe we just need to be more explicit about which source directories are included in ant build file that we generate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant