Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP-ENUM thread worker is delayed by network request #23

Open
hrkck opened this issue Sep 8, 2020 · 0 comments
Open

SIP-ENUM thread worker is delayed by network request #23

hrkck opened this issue Sep 8, 2020 · 0 comments

Comments

@hrkck
Copy link
Contributor

hrkck commented Sep 8, 2020

The issue is best described in the picture below.

This bug is very hard to catch. It will most certainly only occur under a slow internet connection.

Here is a walkthrough of what is happening:

1 - The threads start running and generating the socket requests.
2 - The workQueue becomes empty after the last package is fed into the thread workers.
3 - Once the queue is all empty, the code goes forward to join all the threads into the main python process (thread.join)

Here is where the issue occurs (and my theory on its cause):

4 - When a network request is still being waited for inside a thread runner, the thread continues to run even though the main python process is terminated. This results in a quacky print where Mr.SIP continues to report its findings after the benchmark output (time duration: 2.99).

Related functions:
def networkScanner()
def sipenum_worker(run_event, option, dest_port, client_ip)

Any help is much appreciated.

sip_enum_issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant