Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata is overwritten by consecutive reconstructions #474

Open
ziw-liu opened this issue Jul 2, 2024 · 3 comments
Open

Metadata is overwritten by consecutive reconstructions #474

ziw-liu opened this issue Jul 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ziw-liu
Copy link
Contributor

ziw-liu commented Jul 2, 2024

The recOrder reconstruction writes its settings into FOV-level .zattrs. However the entire setting object is dumped, so the next channel will overwrite the settings, leaving only the last one.

@ziw-liu ziw-liu added the bug Something isn't working label Jul 2, 2024
@ziw-liu
Copy link
Contributor Author

ziw-liu commented Jul 2, 2024

output_dataset.zattrs["settings"] = settings.dict()

@talonchandler
Copy link
Collaborator

Thanks @ziw-liu.

Do you think something like this is the right move?
output_dataset.zattrs[f"settings-{output_channel_name}"] = settings.dict()

cc @edyoshikun

@ziw-liu
Copy link
Contributor Author

ziw-liu commented Jul 2, 2024

Thanks @ziw-liu.

Do you think something like this is the right move? output_dataset.zattrs[f"settings-{output_channel_name}"] = settings.dict()

cc @edyoshikun

I think this is also a chance to use namespacing, as the generic 'settings' field can collide with other things. So something like:

"recOrder-napari":{
    "channel 1": {},
    "channel 2": {},
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants