added option to parse through TS or DAC #318
Conversation
Codecov Report
@@ Coverage Diff @@
## main #318 +/- ##
========================================
- Coverage 7.23% 7.22% -0.01%
========================================
Files 25 25
Lines 4439 4440 +1
========================================
Hits 321 321
- Misses 4118 4119 +1
|
|
Preview page for your plugin is ready here: |
|
Thanks @edyoshikun.
Thanks @ziw-liu. I'll move this to a separate issue. |
|
I realized this will fail if the name of the Triggerscope is back to to 'TS' since the |
There was a problem hiding this comment.
This is not a permanent solution still. We should allow the users to name their DAQ device arbitrarily, and potentially use an Arduino or NI DAQ instead of a TriggerScope. DACs are registered as SignalIODevice. We should check for that using mmc. getDeviceType. Here is the SignalIODevice API: https://github.com/micro-manager/mmCoreAndDevices/blob/77ccd434cb84b86892b5544d1bf17aafa57cacdd/MMDevice/MMDevice.h#L881
|
@edyoshikun will revisit this in preparation for polarization experiments on mantis. |
There was no need to enumerate the devices as this reads the
State0config properties and looks for devices withTS. As long as the channels have been set properly, the current implementation works well.Additionally, there was no current need to add another dropbox for the DAC device, but perhaps in the future if users are are using DACs other than the triggerscope the if/else case should be changed to look for just
DACinstead.Tested this on Mantis. Fixes #312