Cannot compile on Windows 10 using SLN

[gesior]

Priority

Low

Area

• Data
• Source
• Docker
• Other

What happened?

@Giorox
After this commit #611 I cannot compile anymore on Windows 10 using .sln file.

It says that there is a bug in shellapi.h as it uses EXTERN_C which is not defined.
This file is part of Windows 10 SDK. I've installed 3 available versions. All have same problem:

After removing:

#include <shellapi.h>

It works again.

IDK what fixed this commit for Giorox, but it looks like it may break build on other machines.

Tested debug/release and 32/64 bit version. Before this commit all worked, after commit all have same problem.

Evaluated preprocessor config:

Maybe there is something different, which makes my shellapi.h does not load winnt.h or guiddef.h (EXTERN_C is defined in these 2 files).

Anyone has idea what can be added in Giorox VS or missing in mine?

What OS are you seeing the problem on?

Windows

Code of Conduct

• I agree to follow this project's Code of Conduct

[Giorox]

This is very weird. I'm not home currently, but when I come back I'll check my project properties, pre-processor configs etc to see if we can find some difference that might cause this.

I am on 64bit Windows, not sure if that might have something to do with this.

[gesior]

Test it few more times. Always with Rebuild Solution.

With this line:

#include <timeapi.h>

it builds Release, but does not build Debug. There are some errors about redefinition of some variables.

With this line:

#include <shellapi.h>

it does not build at all.

I will install clean Windows 10 in VM and run VS2022 there.

[gesior]

After last Mehah commit I can compile all versions (release/debug 32/64) on my Windows 10 and Ubuntu 22.04.
@Giorox Can you confirm that it works on your VS2022 too?

[Giorox]

After last Mehah commit I can compile all versions (release/debug 32/64) on my Windows 10 and Ubuntu 22.04.
@Giorox Can you confirm that it works on your VS2022 too?

I can compile aswell over here, seems like that fixes it :)