Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance problem when killing a lot of monsters at the same time on screen. #609

Closed
2 of 5 tasks
conde2 opened this issue Oct 28, 2023 · 5 comments
Closed
2 of 5 tasks

Performance problem when killing a lot of monsters at the same time on screen. #609

conde2 opened this issue Oct 28, 2023 · 5 comments
Labels
Priority: High Represent a high impact in key areas of the base/user experience Stale Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@conde2
Copy link
Collaborator

conde2 commented Oct 28, 2023

Priority

High

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

If there are a lot of monsters in screen and you kill all them at the same time there is a freeze in the client

OTClient.-.Redemption.2023-10-28.18-14-40.mp4

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@conde2 conde2 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 28, 2023
@github-actions github-actions bot added Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing labels Oct 28, 2023
@conde2
Copy link
Collaborator Author

conde2 commented Oct 29, 2023 •
edited
Loading

After some investigation the problem was found in the game_console, because there is a lot of messages being added to the Server Log (a lot of new widgets being created simultaniusly) the client freezes.

Propoused solution: Create and cache some widgets at the startup and reuse them when adding a new message to server log.

image

@csantbr
Copy link
Collaborator

csantbr commented Nov 6, 2023 •
edited
Loading

Contributing my 2 cents haha, when testing on protocol 10.98 and TFS 1.4.2 the same thing happens here.

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 120 days with no activity.

@github-actions github-actions bot added the Stale label Feb 23, 2024
@mehah mehah closed this as completed Mar 10, 2024
@luanluciano93
Copy link
Collaborator

sorted out?

@mehah
Copy link
Owner

mehah commented Mar 11, 2024

@luanluciano93
I believe so, there was a critical correction when creating the widgets and I am almost certain that this was what was causing the lag reported by this issue.

commit: a75536d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: High Represent a high impact in key areas of the base/user experience Stale Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@conde2 @mehah @luanluciano93 @csantbr