Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thanks for your enjoy!i have a try in sidd dataset of HINet,but it gives me " TypeError: 'NoneType' object is not subscriptable",look for your reply,thank you! #2

Open
zxcvads opened this issue Dec 28, 2021 · 4 comments

Comments

@zxcvads
Copy link

zxcvads commented Dec 28, 2021

No description provided.

@achusky
Copy link
Collaborator

achusky commented Dec 28, 2021

Thank you for your feedback. We fixed the issue in the latest update.
It is worth mentioning that, the training size and test size for HINet on SIDD dataset are both 256x256, so there is no train-test inconsistency as mentioned in the paper.

@zxcvads
Copy link
Author

zxcvads commented Dec 28, 2021

Thank you for your feedback. We fixed the issue in the latest update. It is worth mentioning that, the training size and test size for HINet on SIDD dataset are both 256x256, so there is no train-test inconsistency as mentioned in the paper.

thanks for your reply! After your fixed code, i faced another bug:
Traceback (most recent call last):
File "basicsr/test_tlsc.py", line 68, in
main()
File "basicsr/test_tlsc.py", line 64, in main
rgb2bgr=rgb2bgr, use_image=use_image)
File "/code/HINet-main/basicsr/models/base_model.py", line 58, in validation
save_img, rgb2bgr, use_image)
File "/code/HINet-main/basicsr/models/image_restoration_model.py", line 323, in nondist_validation
self.grids() #apply for demo.py
File "/code/HINet-main/basicsr/models/image_restoration_model.py", line 132, in grids
num_row = (h - 1) // crop_size + 1
TypeError: unsupported operand type(s) for //: 'int' and 'NoneType'
0%| | 0/1280 [00:00<?, ?image/s]

@zxcvads
Copy link
Author

zxcvads commented Dec 28, 2021

Thank you for your feedback. We fixed the issue in the latest update. It is worth mentioning that, the training size and test size for HINet on SIDD dataset are both 256x256, so there is no train-test inconsistency as mentioned in the paper.

Thank you for your feedback. We fixed the issue in the latest update. It is worth mentioning that, the training size and test size for HINet on SIDD dataset are both 256x256, so there is no train-test inconsistency as mentioned in the paper.

Besides, my sidd datasets preparation is referenced by HINet, https://github.com/megvii-model/HINet/blob/main/scripts/data_preparation/sidd.py,

@achusky
Copy link
Collaborator

achusky commented Dec 28, 2021

Hi, perhaps you are using an older version of HINet code. You may set grids: false in config or update the code of image_restoration_model.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants