Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs and Navbar #71

Closed
wants to merge 5 commits into from
Closed

Tabs and Navbar #71

wants to merge 5 commits into from

Conversation

utkarshnashine
Copy link

PR for tabs + navbar

@vercel
Copy link

vercel bot commented Mar 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/megabyte-143/certified-cliche/BV5u2HsKmsnnRS9gomgxCuYz6WVa
✅ Preview: Failed

[Deployment for 1fa57b2 failed]

@raysummee
Copy link
Collaborator

@utkarshnashine I left some reviews, fix those. Let me know if you can access it or not. Overall looking good 👍

@raysummee
Copy link
Collaborator

@utkarshnashine Some changes needed to be done:

  • Remove config.js file from the commit. It should not be changed
  • Use module.css instead of pure css
  • remove index.js from the commit
  • Don't add component specific styling in global.css

@megabyte0x megabyte0x linked an issue Mar 23, 2022 that may be closed by this pull request
@megabyte0x
Copy link
Owner

@utkarshnashine Any updates on this ?

@megabyte0x megabyte0x added assigned GSSoC22 Girl Script Summer of Code 2022 2-Days Submission in 2 Days labels Mar 23, 2022
@utkarshnashine
Copy link
Author

It is completed all files have been changed according to details,just I need one day tommorow.as ese has disrupted the schedule

@megabyte0x
Copy link
Owner

@utkarshnashine any updates?

@utkarshnashine
Copy link
Author

Yes sir all the files have been arranged and made,just facing some issues in how to remove unneccessary commits

@utkarshnashine
Copy link
Author

As they are causing problem with vercel should I clone it again?

@megabyte0x
Copy link
Owner

@utkarshnashine No need to clone again but there are conflicts in the code. Please resolve them asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-Days Submission in 2 Days assigned GSSoC22 Girl Script Summer of Code 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components - Navbar + tabs
3 participants