Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-6141: Update options for existing relationship #2234

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Feb 25, 2025

Description

After debugging various cases on Live, I discovered that metadata already exists, but the target is already part of another source. Therefore, based on our method for creating relationships, it returns the existing one without setting metadata options.

  • Add relationship ID to the logged message.
  • Update options for existing relationship.

References: CV2-6141

How to test?

Re-run automated tests

Checklist

  • I have performed a self-review of my code and ensured that it is safe and runnable, that code coverage has not decreased, and that there are no new Code Climate issues. I have also followed Meedan's internal coding guidelines.

@melsawy melsawy marked this pull request as ready for review February 25, 2025 09:18
@melsawy melsawy requested a review from caiosba February 25, 2025 17:21
Copy link

codeclimate bot commented Feb 25, 2025

Code Climate has analyzed commit 4a43e2c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@melsawy melsawy requested a review from caiosba February 26, 2025 06:13
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sawy for addressing the comments from the previous reviews!

@melsawy melsawy merged commit 8c3871a into develop Feb 26, 2025
16 checks passed
@melsawy melsawy deleted the CV2-6141-bot-alegre-error-alegre-bad-relationship-was-stored-without-required-metadata branch February 26, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants