Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions workflows #2226

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Fix GitHub Actions workflows #2226

merged 13 commits into from
Feb 19, 2025

Conversation

dmou
Copy link
Contributor

@dmou dmou commented Feb 18, 2025

Description

Fixes failing builds/pushes to ECR by removing arm platform, and cleans up workflow yaml. Upgrades deprecated GitHub actions.

References: CV2-6062

How to test?

Tests pass in CI workflows and successfully upload images. Subsequent commits refresh build cache.

Checklist

  • I have performed a self-review of my code and ensured that it is safe and runnable, that code coverage has not decreased, and that there are no new Code Climate issues. I have also followed Meedan's internal coding guidelines.

@dmou dmou requested a review from caiosba February 18, 2025 21:45
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I see that the "push to ECR" job passed. Thanks for removing trailing white spaces too!

@dmou dmou merged commit 37f812e into develop Feb 19, 2025
11 checks passed
@dmou dmou deleted the CV2-6062/fix-gha-workflows branch February 19, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants