Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop storing search results as suggestions #1797

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Stop storing search results as suggestions #1797

merged 1 commit into from
Feb 12, 2024

Conversation

jayjay-w
Copy link
Contributor

@jayjay-w jayjay-w commented Feb 9, 2024

Description

Stop manually-creating suggestions between the item created from the user request and search results.

REFERENCES: CV2-4206

How has this been tested?

Ensure that all tests and checks are passing.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@jayjay-w jayjay-w changed the title Stop storing search results as suggestins Stop storing search results as suggestions Feb 9, 2024
@jayjay-w jayjay-w force-pushed the CV2-4206-stop-storing-search-results-as-suggestions branch from 5a391f8 to 38b86b6 Compare February 9, 2024 21:27
@jayjay-w
Stop storing search results as suggestins
6b4bf7f 
During our attempt to get user feedback, we created a new workflow
to log all returned content as suggestions. This creates unnecessary
work for Check users.
@jayjay-w jayjay-w force-pushed the CV2-4206-stop-storing-search-results-as-suggestions branch from 38b86b6 to 6b4bf7f Compare February 12, 2024 11:55
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 12, 2024

Code Climate has analyzed commit 6b4bf7f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@jayjay-w jayjay-w marked this pull request as ready for review February 12, 2024 13:36
melsawy
melsawy approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@melsawy melsawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayjay-w @caiosba what about the current suggested items shall we add a rake task to delete suggestion items created by smooch user or should keep these items?

@caiosba
Copy link
Contributor

caiosba commented Feb 12, 2024

@jayjay-w @caiosba what about the current suggested items shall we add a rake task to delete suggestion items created by smooch user or should keep these items?

No need, @melsawy :)

But things for flagging, it's a good point.

@jayjay-w jayjay-w merged commit a5948bf into develop Feb 12, 2024
8 checks passed
@jayjay-w jayjay-w deleted the CV2-4206-stop-storing-search-results-as-suggestions branch March 26, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melsawy melsawy melsawy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayjay-w @caiosba @melsawy