Fixing Alegre path for tipline image search. #1776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tipline image search, and actually other places of the code, were still hitting a deprecated path of Alegre API,
:type/similarity/search
, while (AFAIU) it should be/similarity/sync/:type
(for audio and image, only). This PR fixes it by creating aget_items_with_similar_media_v2
method that hits the new endpoint for image and audio and the old endpoint for video and text. This is not the ideal and I also noticed another problem, but I added a couple of#FIXME
's to the code to handle that later.Reference: CV2-4044.
How has this been tested?
Existing tests should cover this, they broke as expected and I fixed them.
Things to pay attention to during code review
I added a couple of
FIXME
's to the code, please check them.Checklist