Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewing uncovered lines #1772

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Reviewing uncovered lines #1772

merged 3 commits into from
Jan 5, 2024

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Jan 5, 2024

Description

The latest refactoring surfaced some uncovered lines. This PR adds a test for part of the code that was left untested and also deletes code that is not needed anymore.

How has this been tested?

All tests should pass and the code should be 100% covered.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link

codeclimate bot commented Jan 5, 2024

Code Climate has analyzed commit 39b1cb5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

post :create, params: { query: query, team: t.slug, file: { '0' => f } }
assert_response :success
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caiosba when you have some time:
I know we talked about this yesterday, but why is this specific test needed? I'm not sure, but I think we talked about the uploading of files in the tipline, there was nothing that was needed regarding that, or are they related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasconsaurus , that part of the code is about uploading multiple files when calling a mutation, so the mutation itself doesn't really matter... since the test is about uploading files, I used a simpler mutation. In practice, yes, we use it in the application for tipline images and annotations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gracias ❤️

@caiosba caiosba requested a review from vasconsaurus January 5, 2024 18:20
@caiosba caiosba merged commit eb0dc5b into develop Jan 5, 2024
7 of 8 checks passed
@caiosba caiosba deleted the fix/uncovered-lines branch January 5, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants