-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reviewing uncovered lines #1772
Conversation
Code Climate has analyzed commit 39b1cb5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
post :create, params: { query: query, team: t.slug, file: { '0' => f } } | ||
assert_response :success | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caiosba when you have some time:
I know we talked about this yesterday, but why is this specific test needed? I'm not sure, but I think we talked about the uploading of files in the tipline, there was nothing that was needed regarding that, or are they related?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vasconsaurus , that part of the code is about uploading multiple files when calling a mutation, so the mutation itself doesn't really matter... since the test is about uploading files, I used a simpler mutation. In practice, yes, we use it in the application for tipline images and annotations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gracias ❤️
Description
The latest refactoring surfaced some uncovered lines. This PR adds a test for part of the code that was left untested and also deletes code that is not needed anymore.
How has this been tested?
All tests should pass and the code should be 100% covered.
Checklist