From fa41a0e234ede04633e85efa114129b7b9686a56 Mon Sep 17 00:00:00 2001 From: manu vasconcelos Date: Wed, 19 Feb 2025 09:53:54 -0300 Subject: [PATCH] Fix failing tests The method signature changed, so I updated the tests. however: should it change? is there a better way to deal with this? --- test/models/media_test.rb | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/test/models/media_test.rb b/test/models/media_test.rb index 76e734462..f6c2ce0f3 100644 --- a/test/models/media_test.rb +++ b/test/models/media_test.rb @@ -630,7 +630,7 @@ def setup test "Claim Media: should save the original_claim and original_claim_hash when created from original claim" do claim = 'This is a claim.' - claim_media = Media.find_or_create_claim_media(claim) + claim_media = Media.find_or_create_claim_media(claim, nil, true) assert_not_nil claim_media.original_claim_hash assert_not_nil claim_media.original_claim @@ -645,7 +645,7 @@ def setup test "Claim Media: should not create duplicate media if media with original_claim_hash exists" do assert_difference 'Claim.count', 1 do - 2.times { Media.find_or_create_claim_media('This is a claim.') } + 2.times { Media.find_or_create_claim_media('This is a claim.', nil, true) } end end @@ -664,7 +664,7 @@ def setup }.to_json WebMock.stub_request(:get, pender_url).with(query: { url: link_url }).to_return(body: link_response) - link_media = Media.find_or_create_link_media(link_url, team) + link_media = Media.find_or_create_link_media(link_url, team, true) assert_not_nil link_media.original_claim_hash assert_not_nil link_media.original_claim @@ -715,10 +715,9 @@ def setup file.write(File.read(File.join(Rails.root, 'test', 'data', 'rails.mp3'))) file.rewind audio_url = "http://example.com/#{file.path.split('/').last}" - ext = File.extname(URI.parse(audio_url).path) WebMock.stub_request(:get, audio_url).to_return(body: file.read, headers: { 'Content-Type' => 'audio/mp3' }) - uploaded_media = Media.find_or_create_uploaded_file_media('UploadedAudio', audio_url, ext) + uploaded_media = Media.find_or_create_uploaded_file_media(audio_url, 'UploadedAudio', true) assert_not_nil uploaded_media.original_claim_hash assert_not_nil uploaded_media.original_claim @@ -738,11 +737,10 @@ def setup file.write(File.read(File.join(Rails.root, 'test', 'data', 'rails.mp3'))) file.rewind audio_url = "http://example.com/#{file.path.split('/').last}" - ext = File.extname(URI.parse(audio_url).path) WebMock.stub_request(:get, audio_url).to_return(body: file.read, headers: { 'Content-Type' => 'audio/mp3' }) assert_difference 'UploadedAudio.count', 1 do - 2.times { Media.find_or_create_uploaded_file_media('UploadedAudio', audio_url, ext) } + 2.times { Media.find_or_create_uploaded_file_media(audio_url, 'UploadedAudio', true) } end end end