From daa0a54a48fb173a8f340afd3282000c483fdc9c Mon Sep 17 00:00:00 2001
From: Jay Joshua <joejoshw@gmail.com>
Date: Mon, 27 Jan 2025 17:59:17 +0300
Subject: [PATCH] Normalize sign up responses

---
 app/controllers/api/v1/registrations_controller.rb | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/controllers/api/v1/registrations_controller.rb b/app/controllers/api/v1/registrations_controller.rb
index 52228a6fc..ff3e5ff0e 100644
--- a/app/controllers/api/v1/registrations_controller.rb
+++ b/app/controllers/api/v1/registrations_controller.rb
@@ -14,6 +14,11 @@ def create
     begin
       duplicate_user = User.get_duplicate_user(resource.email, [])[:user]
       user = resource
+      error = [
+        {
+          message: I18n.t(:email_exists)
+        }
+      ]
       if !duplicate_user.nil? && duplicate_user.invited_to_sign_up?
         duplicate_user.accept_invitation_or_confirm
         duplicate_user.password = resource.password
@@ -28,7 +33,7 @@ def create
 
       User.current = user
       sign_up(resource_name, user)
-      render_success user, 'user', 401
+      render_success user, 'user', 401, error
     rescue ActiveRecord::RecordInvalid => e
       # Check if the error is specifically related to the email being taken
       if resource.errors.details[:email].any? { |error| error[:error] == :taken } && resource.errors.details.except(:email).empty?
@@ -36,11 +41,6 @@ def create
         duplicate_user = User.get_duplicate_user(resource.email, [])[:user]
         User.current = duplicate_user if duplicate_user
         sign_up(resource_name, duplicate_user)
-        error = [
-          {
-            message: I18n.t(:email_exists)
-          }
-        ]
         render_success nil, 'user', 401, error
       else
         # For other errors, show the error message in the form