From bbb9235aa4e043a2e37a7703826b89f0e1f2147c Mon Sep 17 00:00:00 2001 From: manu vasconcelos Date: Fri, 24 Jan 2025 08:43:31 -0300 Subject: [PATCH] update test and update create_claim_media to look for original_claim --- app/models/concerns/project_media_creators.rb | 2 +- test/models/project_media_7_test.rb | 12 +++++------- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/app/models/concerns/project_media_creators.rb b/app/models/concerns/project_media_creators.rb index fc10d2684..783374ddc 100644 --- a/app/models/concerns/project_media_creators.rb +++ b/app/models/concerns/project_media_creators.rb @@ -100,7 +100,7 @@ def download_file(url, ext) end def create_claim_media(text) - Claim.create!(quote: text, original_claim: text) + Claim.find_by(original_claim: text) || Claim.create!(quote: text, original_claim: text) end def create_link_media(url) diff --git a/test/models/project_media_7_test.rb b/test/models/project_media_7_test.rb index 95e949f63..ee37c1369 100644 --- a/test/models/project_media_7_test.rb +++ b/test/models/project_media_7_test.rb @@ -243,14 +243,12 @@ def setup end end - # For whatever reason this last test is actually creating 4 Medias: 2 Claims and 2 Links - # I don't think it should create the Link Medias test "should check if the original_claim exists and return that instance when trying to create media" do - t = create_team - create_project team: t + text = 'This is a claim.' - assert_difference 'Media.count', 1 do - 2.times { create_project_media(team: t, set_original_claim: 'This is a claim.') } - end + claim = Claim.create!(quote: text, original_claim: text) + pm = create_project_media(set_original_claim: text) + + assert_equal claim.id, pm.media.id end end