From ca82cb3e146e73c95f2db1fccc5dafab82216342 Mon Sep 17 00:00:00 2001 From: Kasper Date: Fri, 29 Sep 2023 07:09:37 +0200 Subject: [PATCH 1/2] fix: set max hight on dropdown content to available height, and set a default collision padding of 8px --- .../dropdown-menu/dropdown-menu.tsx | 47 ++++++++++++------- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/packages/ui/src/components/dropdown-menu/dropdown-menu.tsx b/packages/ui/src/components/dropdown-menu/dropdown-menu.tsx index 19a5a61..031e078 100644 --- a/packages/ui/src/components/dropdown-menu/dropdown-menu.tsx +++ b/packages/ui/src/components/dropdown-menu/dropdown-menu.tsx @@ -42,12 +42,13 @@ SubMenuTrigger.displayName = "DropdownMenu.SubMenuTrigger" const SubMenuContent = React.forwardRef< React.ElementRef, React.ComponentPropsWithoutRef ->(({ className, ...props }, ref) => ( +>(({ className, collisionPadding = 8, ...props }, ref) => ( , React.ComponentPropsWithoutRef ->(({ className, sideOffset = 8, align = "start", ...props }, ref) => ( - - - -)) +>( + ( + { + className, + sideOffset = 8, + collisionPadding = 8, + align = "start", + ...props + }, + ref + ) => ( + + + + ) +) Content.displayName = "DropdownMenu.Content" const Item = React.forwardRef< From c671e6f3920a8138a26f4825254c0ad3ab4b3a53 Mon Sep 17 00:00:00 2001 From: Kasper Date: Tue, 3 Oct 2023 11:28:02 +0200 Subject: [PATCH 2/2] update lock file --- yarn.lock | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/yarn.lock b/yarn.lock index d74460b..ce4fbbb 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7477,7 +7477,7 @@ __metadata: "class-variance-authority@patch:class-variance-authority@npm%3A0.6.1#./.yarn/patches/class-variance-authority-npm-0.6.1-22a468e86e.patch::locator=medusa-ui%40workspace%3A.": version: 0.6.1 - resolution: "class-variance-authority@patch:class-variance-authority@npm%3A0.6.1#./.yarn/patches/class-variance-authority-npm-0.6.1-22a468e86e.patch::version=0.6.1&hash=4a9eff&locator=medusa-ui%40workspace%3A." + resolution: "class-variance-authority@patch:class-variance-authority@npm%3A0.6.1#./.yarn/patches/class-variance-authority-npm-0.6.1-22a468e86e.patch::version=0.6.1&hash=1b9fe4&locator=medusa-ui%40workspace%3A." dependencies: clsx: 1.2.1 checksum: 095af67867a627d20fcd214172afbd4a25350f7852078f1966d74692926c5832e2a20c8746724d514dbeab210252e82775bff2257fcf8e40f99c3d6e5fcfc445 @@ -9642,7 +9642,7 @@ __metadata: "fsevents@patch:fsevents@^2.3.2#~builtin, fsevents@patch:fsevents@~2.3.2#~builtin": version: 2.3.2 - resolution: "fsevents@patch:fsevents@npm%3A2.3.2#~builtin::version=2.3.2&hash=18f3a7" + resolution: "fsevents@patch:fsevents@npm%3A2.3.2#~builtin::version=2.3.2&hash=df0bf1" dependencies: node-gyp: latest conditions: os=darwin @@ -13700,7 +13700,7 @@ __metadata: "resolve@patch:resolve@^1.1.7#~builtin, resolve@patch:resolve@^1.10.0#~builtin, resolve@patch:resolve@^1.14.2#~builtin, resolve@patch:resolve@^1.17.0#~builtin, resolve@patch:resolve@^1.22.1#~builtin, resolve@patch:resolve@^1.22.2#~builtin": version: 1.22.4 - resolution: "resolve@patch:resolve@npm%3A1.22.4#~builtin::version=1.22.4&hash=07638b" + resolution: "resolve@patch:resolve@npm%3A1.22.4#~builtin::version=1.22.4&hash=c3c19d" dependencies: is-core-module: ^2.13.0 path-parse: ^1.0.7 @@ -13713,7 +13713,7 @@ __metadata: "resolve@patch:resolve@^2.0.0-next.4#~builtin": version: 2.0.0-next.4 - resolution: "resolve@patch:resolve@npm%3A2.0.0-next.4#~builtin::version=2.0.0-next.4&hash=07638b" + resolution: "resolve@patch:resolve@npm%3A2.0.0-next.4#~builtin::version=2.0.0-next.4&hash=c3c19d" dependencies: is-core-module: ^2.9.0 path-parse: ^1.0.7 @@ -15446,7 +15446,7 @@ __metadata: "typescript@patch:typescript@5.1.6#~builtin, typescript@patch:typescript@^5.1.6#~builtin": version: 5.1.6 - resolution: "typescript@patch:typescript@npm%3A5.1.6#~builtin::version=5.1.6&hash=7ad353" + resolution: "typescript@patch:typescript@npm%3A5.1.6#~builtin::version=5.1.6&hash=77c9e2" bin: tsc: bin/tsc tsserver: bin/tsserver