Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Polish language support #9770

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: add Polish language support #9770

wants to merge 3 commits into from
+2,845 −1

Conversation

nexthis
Copy link

@nexthis nexthis commented Oct 24, 2024

No description provided.

@nexthis nexthis requested a review from a team as a code owner October 24, 2024 13:37
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 904982d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024

@nexthis is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

kasperkristensen
kasperkristensen previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@kasperkristensen kasperkristensen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR @nexthis!

We will add a test suite that translations will need to pass. I am to have it ready by Monday, so will re-approve the PR then, if it passes said test.

Note on Community Translations
We greatly appreciate all PRs that help make Medusa accessible in more languages. However, we aren't able to validate that all translations are correct. Therefore, we rely on the community to ensure the translations are accurate and appropriate. If you see a translation that is incorrect, has missing keys, or has other issues, please open a PR to correct it.

@kasperkristensen kasperkristensen dismissed their stale review October 25, 2024 14:52

Awaiting test for validating that translations follow schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperkristensen kasperkristensen kasperkristensen left review comments

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nexthis @kasperkristensen