Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse 204 response #25

Open
2 tasks
ashwini-desai opened this issue Aug 7, 2020 · 0 comments
Open
2 tasks

Parse 204 response #25

ashwini-desai opened this issue Aug 7, 2020 · 0 comments
Labels
design discussion required Issue that needs discussion with maintainers for deciding on approach hacktoberfest

Comments

@ashwini-desai
Copy link
Collaborator

ashwini-desai commented Aug 7, 2020

Usually 204 response would not have content. Current ResponseBodyPraser fails as it expects content to be present in all responses.

  • Parse 204 response with nothing to return
  • Set response status to 204 and not 200
delete:
      description: deletes a single pet based on the ID supplied
      operationId: deletePet
      parameters:
        - name: id
          in: path
          description: ID of pet to delete
          required: true
          schema:
            type: integer
            format: int64
      responses:
        '204':
          description: pet deleted
@kdabir kdabir added hacktoberfest design discussion required Issue that needs discussion with maintainers for deciding on approach labels Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design discussion required Issue that needs discussion with maintainers for deciding on approach hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants