From 5a36aea5abfb521745f2933a3a3c503e1f1ef2a0 Mon Sep 17 00:00:00 2001 From: Sugat Bajracharya Date: Tue, 8 Oct 2024 14:00:02 +0545 Subject: [PATCH 1/2] fix(#635): update upload-artifact GH action to version 4 --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 21ddf30f..a0a35338 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -25,7 +25,7 @@ jobs: - name: npm ci and test run: npm ci && npm test - name: Archive Results - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 with: name: Coverage Report ${{ matrix.node-version }} path: | From f7f997ab98245ed47005d34532ae81075af51bdb Mon Sep 17 00:00:00 2001 From: m5r Date: Wed, 9 Oct 2024 17:12:26 +0200 Subject: [PATCH 2/2] fix e2e tests --- test/e2e/edit-app-settings.spec.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/e2e/edit-app-settings.spec.js b/test/e2e/edit-app-settings.spec.js index f44be9e6..c5f56349 100644 --- a/test/e2e/edit-app-settings.spec.js +++ b/test/e2e/edit-app-settings.spec.js @@ -12,6 +12,7 @@ const { describe('edit-app-settings', () => { const projectName = DEFAULT_PROJECT_NAME; + const findLanguage = (settingsLanguages, locale) => settingsLanguages.find(language => language.locale === locale); before(async () => { await initProject(projectName); @@ -24,7 +25,8 @@ describe('edit-app-settings', () => { it('disables a language, recompile, and push app settings', async () => { const url = await getProjectUrl(projectName); const baseSettings = await request.get({ url: `${url}/api/v1/settings`, json: true }); - baseSettings.languages.forEach(language => expect(language.enabled).to.be.true); + expect(findLanguage(baseSettings.languages, 'en').enabled).to.be.true; + expect(findLanguage(baseSettings.languages, 'fr').enabled).to.be.true; expect(baseSettings.locale).to.equal('en'); expect(baseSettings.locale_outgoing).to.equal('en');