Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing logs from uncaught errors when filling forms #137

Open
derickl opened this issue Sep 9, 2021 · 1 comment · May be fixed by #142
Open

Missing logs from uncaught errors when filling forms #137

derickl opened this issue Sep 9, 2021 · 1 comment · May be fixed by #142
Assignees

Comments

@derickl
Copy link
Member

derickl commented Sep 9, 2021

Describe the bug
Some form errors crash enketo and are not logged

To Reproduce
Assuming you have a question name and a calculate household_name that concatenates name with Household, the expression would fail to evaluate if name had a " character as part of its input.

The following failure is in cht-core.

Could not evaluate: concat(../../contact/name, ' Household'), message: Failed to execute 'evaluate' on 'Document': The string 'concat("He A"", " Household")' is not a valid XPath expression.

The following is a stack trace from harness from an uncaught error

Error: Evaluation failed: FormLogicError
at ExecutionContext._evaluateInternal (node_modules/puppeteer-core/lib/cjs/puppeteer/common/ExecutionContext.js:221:19)
at process._tickCallback (internal/process/next_tick.js:68:7)

What did you expect?
A clear description of the error

Screenshots
If applicable, add screenshots to help explain your problem.

Environment:
Desktop: Latest Chrome & Firefox

@derickl derickl self-assigned this Sep 9, 2021
@derickl derickl linked a pull request Sep 29, 2021 that will close this issue
@KicaRonaldOkello
Copy link

The exact example given in this issue has been fixed in the later versions of harness. The expression evaluates. @derickl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants