Passing values with double-quotes to harness inputs crashes enketo

[derickl]

Assuming you have a question name and a calculate household_name that concatenates name with Household, the expression would fail to evaluate if name had a " character as part of its input.

The following failure is in both cht-core and harness.

Could not evaluate: concat(../../contact/name, ' Household'), message: Failed to execute 'evaluate' on 'Document': The string 'concat("He A"", " Household")' is not a valid XPath expression.

This is a limitation of XPath 1.0 which does not provide a way of quoting double-quotes. Newer XPath standards support this but unfortunately most (if not all) browsers support XPath 1.0

Additional information:

REF branch

What happened?

Register household members with name, Je"n Claude, should throw a validation error:
     Error: Evaluation failed: FormLogicError
      at ExecutionContext._evaluateInternal (node_modules/puppeteer-core/lib/cjs/puppeteer/common/ExecutionContext.js:221:19)

What did you expect?

Error encountered while filling form: [
    ✓ Register household members with name, Je"n Claude, should throw a validation error (...ms)
  {
    "type": "validation",
    "question": "Name*\nName should not contain integer or non-alphanumeric characters",
    "msg": "Name should not contain integer or non-alphanumeric characters"
  }
]