Skip to content

Commit 82a477e

Browse files
author
Ashoka de Wit
committed
Remove marketplace standard until it is compatible with PHPCS3
1 parent 9b31243 commit 82a477e

File tree

3 files changed

+9
-51
lines changed

3 files changed

+9
-51
lines changed

README.md

+6-8
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
# Introduction
22

3-
This is the MediaCT coding standard for Magento 2 projects. It is a mix of the
4-
default MediaCT coding standard and the Magento marketplace standard.
5-
6-
Some tests have been removed from both of the standards to create a workable
7-
and fast standard.
3+
This is the MediaCT coding standard for Magento 2 projects. It is based on
4+
the default MediaCT coding standard but some tests have been removed to create
5+
a workable and fast standard.
86

97
# Installation
108

119
Use composer to require the standard in a project.
1210

1311
```shell
14-
$ composer require --dev mediact/coding-standard-magento2
12+
composer require --dev mediact/coding-standard-magento2
1513
```
1614

1715
To let PHPCS know that this standard should be used add a phpcs.xml file in the
@@ -30,12 +28,12 @@ The recommended way to enable the coding standard in PHPStorm and automatic
3028
testing is by requiring the MediaCT testing suite in a project.
3129

3230
```shell
33-
$ composer require --dev mediact/testing-suite
31+
composer require --dev mediact/testing-suite
3432
```
3533

3634
For more information go to [MediaCT Testing Suite](https://github.com/mediact/testing-suite).
3735

3836
# Contribution guidelines
3937

4038
Contributions are welcome. Please create pull requests which add or remove
41-
tests.
39+
tests.

composer.json

+1-12
Original file line numberDiff line numberDiff line change
@@ -10,23 +10,12 @@
1010
"email": "[email protected]"
1111
}
1212
],
13-
"repositories": [
14-
{
15-
"type": "composer",
16-
"url": "https://composer.mediact.nl"
17-
},
18-
{
19-
"type": "composer",
20-
"url": "https://repo.magento.com"
21-
}
22-
],
2313
"require": {
24-
"magento/marketplace-eqp": "^1.0",
2514
"mediact/coding-standard": "@stable"
2615
},
2716
"autoload": {
2817
"psr-0": {
2918
"MediactMagento2": "src/MediactMagento2"
3019
}
3120
}
32-
}
21+
}

src/MediactMagento2/ruleset.xml

+2-31
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
* https://www.mediact.nl
66
*/
77
-->
8-
<ruleset name="Mediact/Magento1">
9-
<description>MediaCT coding standards for Magento1.</description>
8+
<ruleset name="Mediact/Magento2">
9+
<description>MediaCT coding standards for Magento2.</description>
1010
<arg name="colors" />
1111
<arg name="extensions" value="php/PHP,phtml/PHP,js/JS,css/CSS" />
1212

@@ -25,35 +25,6 @@
2525
<exclude name="Generic.PHP.Syntax"/>
2626
</rule>
2727

28-
<!-- Base rules on Magento Marketplace -->
29-
<rule ref="../../../../magento/marketplace-eqp/MEQP1">
30-
<exclude name="MEQP1.Classes"/>
31-
<exclude name="MEQP1.PHP.PrivateClassMember"/>
32-
<exclude name="MEQP1.Exceptions.DirectThrow"/>
33-
<exclude name="MEQP1.PHP.Syntax"/>
34-
<exclude name="MEQP1.Security.Acl"/>
35-
<exclude name="MEQP1.Security.Superglobal"/>
36-
<exclude name="MEQP1.Classes.ObjectInstantiation"/>
37-
<exclude name="MEQP1.Stdlib.DateTime"/>
38-
<exclude name="MEQP1.SQL.MissedIndexes"/>
39-
<exclude name="MEQP1.SQL.SlowQuery"/>
40-
<exclude name="MEQP1.Security.DiscouragedFunction" />
41-
<exclude name="MEQP1.Performance.Loop" />
42-
<exclude name="Generic.Functions.OpeningFunctionBraceBsdAllman" />
43-
<exclude name="Zend.NamingConventions.ValidVariableName.PrivateNoUnderscore"/>
44-
</rule>
45-
<rule ref="../../../../magento/marketplace-eqp/MEQP2">
46-
<exclude name="PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket"/>
47-
<exclude name="MEQP2.PHP.Syntax"/>
48-
<exclude name="Generic.Arrays.DisallowShortArraySyntax" />
49-
<exclude name="Generic.CodeAnalysis.UnusedFunctionParameter.Found"/>
50-
</rule>
51-
52-
<rule ref="Squiz.PHP.CommentedOutCode">
53-
<properties>
54-
<property name="maxPercentage" value="80"/>
55-
</properties>
56-
</rule>
5728
<rule ref="Generic.Files.LineLength.TooLong">
5829
<exclude-pattern>*.phtml</exclude-pattern>
5930
</rule>

0 commit comments

Comments
 (0)