Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store solver versions in BaseSolver #42

Open
ewu63 opened this issue Feb 5, 2021 · 3 comments
Open

Store solver versions in BaseSolver #42

ewu63 opened this issue Feb 5, 2021 · 3 comments

Comments

@ewu63
Copy link
Collaborator

ewu63 commented Feb 5, 2021

Description of feature

There should be a way (via inheritance) to access and store the version of the inherited class instance. This can then be used in printing to make clear what version of the specific solver is.

@marcomangano
Copy link
Contributor

Is this going to be redundant when Repostate is updated?

@ewu63
Copy link
Collaborator Author

ewu63 commented Mar 7, 2022

Hmm, this was aimed at a slightly different use case, i.e. accessing say CFDSolver.__version__ or something to fetch its version at run time. Then you can for example have different aeroOptions depending on the version if something was removed/added recently. But this is probably low priority, I don't see much use for this. I'd be okay with closing this if nobody is interested in this feature.

@marcomangano
Copy link
Contributor

We can bring this up again and see if anyone is interested, your comment makes the scope more clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants