Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root_add_dict should fail if the dict does not match exactly #19

Open
ewu63 opened this issue Nov 21, 2020 · 0 comments
Open

root_add_dict should fail if the dict does not match exactly #19

ewu63 opened this issue Nov 21, 2020 · 0 comments

Comments

@ewu63
Copy link
Collaborator

ewu63 commented Nov 21, 2020

Description

Say you have a dictionary in the reference file, and use root_add_dict for training/testing. If the reference dictionary is a superset of the dictionary generated from testing, then the test is considered to pass, since we just loop over the generated dictionary keys, rather than the reference dictionary keys.

Steps to reproduce issue

Imagine if the reference JSON file contained the following dictionary

{'a':1, 'b':2, 'c':3}

and the dictionary generated by the test is

{'a':1, 'b':2}

Current behavior

root_add_dict will consider the test to be successful.

Expected behavior

The test should fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant