Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Suggestion: Do you have any plan to add tests? #120

Closed
DanKim0213 opened this issue Feb 14, 2024 · 4 comments
Closed

Content Suggestion: Do you have any plan to add tests? #120

DanKim0213 opened this issue Feb 14, 2024 · 4 comments

Comments

@DanKim0213
Copy link

Hi, I love this todo-react project and I've learned so much about React through this project.

However, I feel starving to learn tests ever since testing is becoming one of the requirements to be hired. I think this project could be a good start for junior frontend developers to learn not only React but also testing :)

Thus, I wonder if you have any plan to add tests with React Testing Library. And, if so, can I pull requests?

Copy link

It looks like this is your first issue. Welcome! 👋
One of the project maintainers will be with you as soon as possible. We
appreciate your patience. To safeguard the health of the project, please
take a moment to read our code of conduct.

@bsmth
Copy link
Member

bsmth commented Feb 14, 2024

Hi, I love this todo-react project and I've learned so much about React through this project.

Hi there 👋🏻 that's really great to hear.

... testing is becoming one of the requirements to be hired. I think this project could be a good start for junior frontend developers to learn not only React but also testing :)

I think that's a really good point. It might be nice to have something generic about functional testing, especially since Node.js has a test runner since Node 20.

Do you want to add an issue here for a feature proposal so we can figure out where it could live?

edit: Thanks a lot for raising this issue, and welcome 😄

@DanKim0213
Copy link
Author

Do you want to add an issue here for a feature proposal so we can figure out where it could live?

Hi, thanks for your reply 👋

I added this issue to MDN for a feature proposal as you said :)

@bsmth
Copy link
Member

bsmth commented Feb 22, 2024

Super, thank you! Let's close this and track progress in your proposal - issues in this repo are moreso for reporting and tracking bugs in the code.

@bsmth bsmth closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants