New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH pages base paths for assets is wrong/missing #102

Closed

bsmth opened this issue Dec 21, 2023 · 1 comment · Fixed by #106

Labels

bug needs triage

Member

bsmth commented Dec 21, 2023

What information was incorrect, unhelpful, or incomplete?

There are some 404s in the deployed site:

❌ 404 https://mdn.github.io/assets/index-u64nDbB7.js
❌ 404 https://mdn.github.io/assets/index-sABYHyHG.css
❌ 404 https://mdn.github.io/vite.svg

What did you expect to see?

Assets loaded relative to base path which is https://mdn.github.io/todo-react/, see

✅ 200 https://mdn.github.io/todo-react/assets/index-u64nDbB7.js
✅ 200 https://mdn.github.io/todo-react/assets/index-sABYHyHG.css
✅ 200 https://mdn.github.io/todo-react/vite.svg

Do you have any supporting links, references, or citations?

After changes landed in:

DO NOT MERGE: Migrate to Vite #97

Do you have anything more you want to share?

No response

bsmth added the needs triage label

This comment was marked as outdated.

Sign in to view

bsmth added the bug label

chrisdavidmills mentioned this issue

Fix base path error #106

Merged

bsmth closed this as completed in #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment