From 98a13b1d7fed7f806434fe014fe58093ca23bd76 Mon Sep 17 00:00:00 2001 From: josuke0227 <45995961+josuke0227@users.noreply.github.com> Date: Sun, 29 Sep 2024 16:41:36 +1000 Subject: [PATCH 1/3] Mute default :focus form highlight The applied border colour (border-color: #000;) is cascaded by the default border highlight (blue colour in Chrome). Therefore I reckon the default styling needs to be muted. --- files/en-us/learn/forms/your_first_form/index.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/files/en-us/learn/forms/your_first_form/index.md b/files/en-us/learn/forms/your_first_form/index.md index a961ef1f442e70b..e6cc019786848e5 100644 --- a/files/en-us/learn/forms/your_first_form/index.md +++ b/files/en-us/learn/forms/your_first_form/index.md @@ -225,6 +225,8 @@ textarea { input:focus, textarea:focus { + /* Mute default highlight */ + outline: none; /* Additional highlight for focused elements */ border-color: #000; } From 98849580e3fa4787ccf808af33c0c6b60230e190 Mon Sep 17 00:00:00 2001 From: Hamish Willee Date: Fri, 18 Oct 2024 12:28:40 +1100 Subject: [PATCH 2/3] Apply suggestions from code review --- files/en-us/learn/forms/your_first_form/index.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/files/en-us/learn/forms/your_first_form/index.md b/files/en-us/learn/forms/your_first_form/index.md index e6cc019786848e5..99fbd11972d8e30 100644 --- a/files/en-us/learn/forms/your_first_form/index.md +++ b/files/en-us/learn/forms/your_first_form/index.md @@ -225,10 +225,10 @@ textarea { input:focus, textarea:focus { - /* Mute default highlight */ - outline: none; - /* Additional highlight for focused elements */ - border-color: #000; + /* Set the outline width and style / + outline-style: solid; + /* To give a little highlight on active elements */ + outline-color: #000; } textarea { From 517d7347007c6cfcb9e2e41a8089e4504a1b8e33 Mon Sep 17 00:00:00 2001 From: Hamish Willee Date: Fri, 18 Oct 2024 13:18:51 +1100 Subject: [PATCH 3/3] Apply suggestions from code review --- files/en-us/learn/forms/your_first_form/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/files/en-us/learn/forms/your_first_form/index.md b/files/en-us/learn/forms/your_first_form/index.md index 99fbd11972d8e30..d81e6dec3c27dfd 100644 --- a/files/en-us/learn/forms/your_first_form/index.md +++ b/files/en-us/learn/forms/your_first_form/index.md @@ -225,7 +225,7 @@ textarea { input:focus, textarea:focus { - /* Set the outline width and style / + /* Set the outline width and style */ outline-style: solid; /* To give a little highlight on active elements */ outline-color: #000;