Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirroring ranged versions removes ranges for most browsers #23855

Closed
2 tasks done
foolip opened this issue Jul 19, 2024 · 2 comments · Fixed by #24155
Closed
2 tasks done

Mirroring ranged versions removes ranges for most browsers #23855

foolip opened this issue Jul 19, 2024 · 2 comments · Fixed by #24155
Labels
bug Confirmed bugs in the repository (i.e. linter bugs), NOT browser implementation bugs. infra Infrastructure issues (npm, GitHub Actions, releases) of this project

Comments

@foolip
Copy link
Contributor

foolip commented Jul 19, 2024

What type of issue is this?

Infrastructure issue

What is the issue?

Both Chrome and Firefox use ranges in this feature:

"allow-forms": {
"__compat": {
"description": "<code>sandbox=\"allow-forms\"</code>",
"spec_url": "https://html.spec.whatwg.org/multipage/browsers.html#attr-iframe-sandbox-allow-forms",
"support": {
"chrome": {
"version_added": "≤49"
},
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": "≤49"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "≤10.1"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror"
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},

The data we publish (after mirroring) is this:

          "allow-forms": {
            "__compat": {
              "description": "<code>sandbox=\"allow-forms\"</code>",
              "source_file": "html/elements/iframe.json",
              "spec_url": "https://html.spec.whatwg.org/multipage/browsers.html#attr-iframe-sandbox-allow-forms",
              "status": {
                "deprecated": false,
                "experimental": false,
                "standard_track": true
              },
              "support": {
                "chrome": {
                  "version_added": "≤49"
                },
                "chrome_android": {
                  "version_added": "49"
                },
                "edge": {
                  "version_added": "79"
                },
                "firefox": {
                  "version_added": "≤49"
                },
                "firefox_android": {
                  "version_added": "49"
                },
                "ie": {
                  "version_added": false
                },
                "oculus": {
                  "version_added": "5.0"
                },
                "opera": {
                  "version_added": "36"
                },
                "opera_android": {
                  "version_added": "36"
                },
                "safari": {
                  "version_added": "≤10.1"
                },
                "safari_ios": {
                  "version_added": "≤10.3"
                },
                "samsunginternet_android": {
                  "version_added": "5.0"
                },
                "webview_android": {
                  "version_added": "49"
                }
              }
            }
          },

Note that there are no ranges for any mirrored data except safari_ios, which is done correctly.

What behavior were you expecting?

Ranges should be preserved for browsers that mirror from Chrome and Firefox.

What version(s) of BCD is the issue present in?

  • The current BCD release
  • The current version of the main branch

Do you have anything more you want to share?

cc @queengooborg

@foolip
Copy link
Contributor Author

foolip commented Jul 19, 2024

@ddbeck @Elchi3 FYI, I discovered this when looking at web-features dist files, surprised to see ranges for Chrome but not Chrome Android.

@queengooborg queengooborg added bug Confirmed bugs in the repository (i.e. linter bugs), NOT browser implementation bugs. infra Infrastructure issues (npm, GitHub Actions, releases) of this project labels Jul 19, 2024
@foolip
Copy link
Contributor Author

foolip commented Jul 19, 2024

I think I've found the bug and I'm writing some tests for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs in the repository (i.e. linter bugs), NOT browser implementation bugs. infra Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
2 participants