Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final todo list for NCrystal 4.0.0 #222

Open
tkittel opened this issue Feb 8, 2025 · 0 comments
Open

Final todo list for NCrystal 4.0.0 #222

tkittel opened this issue Feb 8, 2025 · 0 comments
Labels
fix-incoming Issues that are solved but not yet released

Comments

@tkittel
Copy link
Member

tkittel commented Feb 8, 2025

Getting close to releasing NCrystal 4.0.0, collecting a few scattered final TODO items here:

#FIXME Address all of the following for the release:

  • Make sure pypi.yml omly triggers for even patch numbers (in addition, we
    should only create even tags!). Document this policy.

  • We should have a way to determine what version of NCrystal a given plugin was
    built against, so we can error on incompatibilities.

  • Make sure pull requests have check boxes on top with stuff like "did you add a
    test", "did you mention any open issues this is linked to", etc.

  • ncdevtool/CI improvements

    • "ncdevtool find" mode seems broken.
    • import sb_devtools_gdb/valgrind?
    • check shebangs consistent
    • check files left outside dirs
    • use inspect module to find missing docstrings in modules and functions
    • python coverage testing.
    • Open issue about migrating more tests from ncrystaldev repo
    • Compile and test also dmsc:ncrystaldev nclong pkgs.
    • Guard against DOS line endings.
  • Support (and test) windows paths starting with "\?", as well as shared
    directories starting with double slashes.

  • plugin docs should contain this info:
    Make CrysText plugin ready for ncrystal v4 highness-eu/ncplugin-CrysText#1 (comment)

conda install ncrystal-all
conda install ncrystal-plugin-support

  • Update wiki to point at HEAD rather than master

  • plugindb.yml: cpp check all plugins? And test all the pip install git+... urls.

  • We should remove the gitref: tags in plugin_database.yml for mctools/ncrystal.

  • We need a CI which tests that there are no missing NCRYSTAL_API declations.

@tkittel tkittel added the fix-incoming Issues that are solved but not yet released label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-incoming Issues that are solved but not yet released
Projects
None yet
Development

No branches or pull requests

1 participant