From a12c4be36822f21a338dd5a2b9924e8152d14b3d Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Fri, 29 Dec 2023 17:14:06 -0500 Subject: [PATCH 1/6] Remove auto assign since we don't use it anymore --- .github/auto_assign.yml | 16 ---------------- 1 file changed, 16 deletions(-) delete mode 100644 .github/auto_assign.yml diff --git a/.github/auto_assign.yml b/.github/auto_assign.yml deleted file mode 100644 index 407ed6d..0000000 --- a/.github/auto_assign.yml +++ /dev/null @@ -1,16 +0,0 @@ -# Set to true to add reviewers to pull requests -addReviewers: true - -# Set to true to add assignees to pull requests -addAssignees: false - -# A list of reviewers to be added to pull requests (GitHub user name) -reviewers: - - zacharyrobin - - KeeyanGhoreshi - - smalho01 - - plarocque4 - - kennyEung - -# A number of reviewers added to the pull request, Set to 0 to add all reviewers -numberOfReviewers: 0 From 06358a28e3ebc45608215df3ef2ded9ef7d5c1e3 Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Fri, 29 Dec 2023 17:16:03 -0500 Subject: [PATCH 2/6] Remove unused file --- README.old.md | 2 -- 1 file changed, 2 deletions(-) delete mode 100644 README.old.md diff --git a/README.old.md b/README.old.md deleted file mode 100644 index 7792133..0000000 --- a/README.old.md +++ /dev/null @@ -1,2 +0,0 @@ -# rems-smart-on-fhir -REMS SMART on FHIR Application From bb4b4e25787ee4f1cab9722081c75010cc0d63d9 Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Fri, 29 Dec 2023 17:16:54 -0500 Subject: [PATCH 3/6] Alphabetize env vars and remove comment since its text is duplicated in the README --- .env | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/.env b/.env index c65871f..307a966 100644 --- a/.env +++ b/.env @@ -1,20 +1,14 @@ -# Development URLS - -REACT_APP_REMS_ADMIN_SERVER_BASE = http://localhost:8090 -REACT_APP_REMS_HOOKS_PATH = /cds-services/rems- -REACT_APP_PHARMACY_SERVER_BASE = http://localhost:5051 -REACT_APP_ETASU_STATUS_ENABLED = true -REACT_APP_PHARMACY_STATUS_ENABLED = true -REACT_APP_SEND_RX_ENABLED = true -REACT_APP_SEND_FHIR_AUTH_ENABLED = false +BROWSER=none +GENERATE_SOURCEMAP=false PORT=4040 +REACT_APP_CLIENT_SCOPES = launch openid profile user/Patient.read patient/Patient.read user/Practitioner.read REACT_APP_DEFAULT_CLIENT_ID = app-login REACT_APP_DEFAULT_ISS = http://localhost:8080/test-ehr/r4 -REACT_APP_CLIENT_SCOPES = launch openid profile user/Patient.read patient/Patient.read user/Practitioner.read REACT_APP_DEVELOPER_MODE = true -GENERATE_SOURCEMAP=false -BROWSER=none - -# To Override start command: -# REACT_APP_REMS_HOOKS_PATH=http://example.com PORT=6000 npm start -# Note that .env values can only be accessed by react app starting with 'REACT_APP_' \ No newline at end of file +REACT_APP_ETASU_STATUS_ENABLED = true +REACT_APP_PHARMACY_SERVER_BASE = http://localhost:5051 +REACT_APP_PHARMACY_STATUS_ENABLED = true +REACT_APP_REMS_ADMIN_SERVER_BASE = http://localhost:8090 +REACT_APP_REMS_HOOKS_PATH = /cds-services/rems- +REACT_APP_SEND_FHIR_AUTH_ENABLED = false +REACT_APP_SEND_RX_ENABLED = true From bc9e7f6ea3aeb9ce05858f576d928f2402c4bf6d Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Fri, 29 Dec 2023 17:17:11 -0500 Subject: [PATCH 4/6] Run Prettier --- README.md | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/README.md b/README.md index 5c750ba..26882c3 100644 --- a/README.md +++ b/README.md @@ -1,10 +1,11 @@ # Getting Started with REMS SMART on FHIR -The REMS SMART on FHIR application can be launched from an EHR that does not support CDS Hooks. The application will interact with the REMS Administrator using CDS Hooks on behalf of the EHR, allowing the provider to complete the normal REMS workflow. +The REMS SMART on FHIR application can be launched from an EHR that does not support CDS Hooks. The application will interact with the REMS Administrator using CDS Hooks on behalf of the EHR, allowing the provider to complete the normal REMS workflow. This application must be launched by an EHR or SMART sandbox imitating an EHR. ## Initialization + After cloning the repository, the submodules must be initialized. To do this you can run: ### `git submodule update --init` @@ -22,25 +23,25 @@ The page will reload if you make edits.\ You will also see any lint errors in the console. ### How To Override Defaults + The .env file contains the default URI paths, these can be overwritten from the start command as follows: - `REACT_APP_REMS_HOOKS_PATH=http://example.com PORT=6000 npm start` - -Following are a list of modifiable paths: +`REACT_APP_REMS_HOOKS_PATH=http://example.com PORT=6000 npm start` -| URI Name | Default | -| ----------- | ----------- | -| REACT_APP_REMS_ADMIN_SERVER_BASE | `http://localhost:8090` | -| REACT_APP_REMS_HOOKS_PATH | `/cds-services/rems-order-sign` | -| REACT_APP_PHARMACY_SERVER_BASE | `http://localhost:5051` | -| REACT_APP_ETASU_STATUS_ENABLED | `true` | -| REACT_APP_PHARMACY_STATUS_ENABLED | `true` | -| REACT_APP_DEVELOPER_MODE | `true` | -| REACT_APP_SEND_RX_ENABLED | `true` | -| REACT_APP_SEND_FHIR_AUTH_ENABLED | `false` | -| PORT | `4040`| +Following are a list of modifiable paths: - *Note that .env values can only be accessed by react app starting with `REACT_APP_`* +| URI Name | Default | +| --------------------------------- | ------------------------------- | +| REACT_APP_REMS_ADMIN_SERVER_BASE | `http://localhost:8090` | +| REACT_APP_REMS_HOOKS_PATH | `/cds-services/rems-order-sign` | +| REACT_APP_PHARMACY_SERVER_BASE | `http://localhost:5051` | +| REACT_APP_ETASU_STATUS_ENABLED | `true` | +| REACT_APP_PHARMACY_STATUS_ENABLED | `true` | +| REACT_APP_DEVELOPER_MODE | `true` | +| REACT_APP_SEND_RX_ENABLED | `true` | +| REACT_APP_SEND_FHIR_AUTH_ENABLED | `false` | +| PORT | `4040` | +_Note that .env values can only be accessed by react app starting with `REACT_APP_`_ ### `npm test` @@ -56,4 +57,3 @@ The build is minified and the filenames include the hashes.\ Your app is ready to be deployed! See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. - From dc0992a154cd90f1942cc94c33c3e369f497268d Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Fri, 29 Dec 2023 17:22:51 -0500 Subject: [PATCH 5/6] Add new env vars and alphabetize them, update links, update section on overriding env vars --- README.md | 37 +++++++++++++++++++++---------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index 26882c3..718bf13 100644 --- a/README.md +++ b/README.md @@ -25,28 +25,33 @@ You will also see any lint errors in the console. ### How To Override Defaults The .env file contains the default URI paths, these can be overwritten from the start command as follows: -`REACT_APP_REMS_HOOKS_PATH=http://example.com PORT=6000 npm start` +`REACT_APP_LAUNCH_URL=http://example.com PORT=6000 npm start` or by specifying the environment variables and desired values in a `.env.local`. Following are a list of modifiable paths: -| URI Name | Default | -| --------------------------------- | ------------------------------- | -| REACT_APP_REMS_ADMIN_SERVER_BASE | `http://localhost:8090` | -| REACT_APP_REMS_HOOKS_PATH | `/cds-services/rems-order-sign` | -| REACT_APP_PHARMACY_SERVER_BASE | `http://localhost:5051` | -| REACT_APP_ETASU_STATUS_ENABLED | `true` | -| REACT_APP_PHARMACY_STATUS_ENABLED | `true` | -| REACT_APP_DEVELOPER_MODE | `true` | -| REACT_APP_SEND_RX_ENABLED | `true` | -| REACT_APP_SEND_FHIR_AUTH_ENABLED | `false` | -| PORT | `4040` | - -_Note that .env values can only be accessed by react app starting with `REACT_APP_`_ +| URI Name | Default | +| --------------------------------- | ------------------------------------------------------------------------------------- | +| BROWSER | `none` | +| GENERATE_SOURCEMAP | `false` | +| PORT | `4040` | +| REACT_APP_CLIENT_SCOPES | `launch openid profile user/Patient.read patient/Patient.read user/Practitioner.read` | +| REACT_APP_DEFAULT_CLIENT_ID | `app-login` | +| REACT_APP_DEFAULT_ISS | `http://localhost:8080/test-ehr/r4` | +| REACT_APP_DEVELOPER_MODE | `true` | +| REACT_APP_ETASU_STATUS_ENABLED | `true` | +| REACT_APP_PHARMACY_SERVER_BASE | `http://localhost:5051` | +| REACT_APP_PHARMACY_STATUS_ENABLED | `true` | +| REACT_APP_REMS_ADMIN_SERVER_BASE | `http://localhost:8090` | +| REACT_APP_REMS_HOOKS_PATH | `/cds-services/rems-` | +| REACT_APP_SEND_FHIR_AUTH_ENABLED | `false` | +| REACT_APP_SEND_RX_ENABLED | `true` | + +_Note that .env values can only be accessed by the React app starting with `REACT_APP_`\_ ### `npm test` Launches the test runner in the interactive watch mode.\ -See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information. +See the section about [running tests](https://create-react-app.dev/docs/running-tests/) for more information. ### `npm run build` @@ -56,4 +61,4 @@ It correctly bundles React in production mode and optimizes the build for the be The build is minified and the filenames include the hashes.\ Your app is ready to be deployed! -See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. +See the section about [deployment](https://create-react-app.dev/docs/deployment/) for more information. From a10abb9e59b8e7fbc730761575e634d89e6235e6 Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Fri, 29 Dec 2023 17:24:26 -0500 Subject: [PATCH 6/6] Fix grammar --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 718bf13..4a0fd6b 100644 --- a/README.md +++ b/README.md @@ -24,8 +24,8 @@ You will also see any lint errors in the console. ### How To Override Defaults -The .env file contains the default URI paths, these can be overwritten from the start command as follows: -`REACT_APP_LAUNCH_URL=http://example.com PORT=6000 npm start` or by specifying the environment variables and desired values in a `.env.local`. +The .env file contains the default URI paths, which can be overwritten from the start command as follows: +a) `REACT_APP_LAUNCH_URL=http://example.com PORT=6000 npm start` or b) by specifying the environment variables and desired values in a `.env.local`. Following are a list of modifiable paths: