chore: minor refactor of base64 handling #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed how inelegant the base64 handling was, mostly due to needing to hard code and handle the valid operations (encode and decode) in two different functions.
mccutchen
force-pushed
the
b64-tweaks
branch
from
359c9ba
to
6b38bdc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage ? 94.91%
=======================================
Files ? 9
Lines ? 1927
Branches ? 0
=======================================
Hits ? 1829
Misses ? 67
Partials ? 31
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed how inelegant the base64 handling was, mostly due to needing to hard code and handle the valid operations (encode and decode) in two different functions.