Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorch feature #4

Open
Rachine opened this issue Nov 30, 2017 · 9 comments
Open

Pytorch feature #4

Rachine opened this issue Nov 30, 2017 · 9 comments

Comments

@Rachine
Copy link

Rachine commented Nov 30, 2017

Hi !

Did you start working on the pytorch feature? Or should I start looking into it?
Thanks for sharing the code!

@mblondel
Copy link
Owner

@arthurmensch is also interested in this. I guess you two could collaborate!

@sculyi
Copy link

sculyi commented Apr 8, 2018

hi, i have the same problem, did you have any ideas?

@amirkargar
Copy link

Hi, did you guys have any progress on this?

@mblondel
Copy link
Owner

Closing since a PyTorch implementation is now available in https://github.com/arthurmensch/didyprog thanks to @arthurmensch.

@shaform
Copy link

shaform commented Feb 6, 2019

It seems like a Pytorch implementation is not really available in that repo arthurmensch/didyprog#5. So maybe this should be reopened?

@mblondel
Copy link
Owner

mblondel commented Feb 8, 2019

@shaform I agree. Does anyone want to tackle it? I won't be able to do it myself, since I don't have the use case myself. Here are the things to do:

  • Create a pytorch function class (https://pytorch.org/docs/stable/notes/extending.html). This should be pretty straightforward (cf. chainer class for inspiration).
  • Write a unit test that makes sure the gradient is correct.
  • Port chainer example in examples/ to pytorch.

@mblondel mblondel reopened this Feb 8, 2019
@lyprince
Copy link

@mblondel Here is my implementation (https://github.com/lyprince/sdtw_pytorch).

I haven't written a proper demo yet, but if this is something people would like and would be relatively easy I could try to make time for it.

@mblondel
Copy link
Owner

mblondel commented Feb 19, 2019 via email

@Maghoumi
Copy link

Maghoumi commented May 2, 2020

@mblondel First, thanks again for your great paper!

I've been extensively using it for my research. I just publicly released a CUDA implementation of your algorithm for PyTorch that can run up to 100x faster than other available implementations. It's availble here: https://github.com/Maghoumi/pytorch-softdtw-cuda

Hope this helps others!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants