Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to update 16kHz access in all notebooks to http #1

Open
danellecline opened this issue Feb 6, 2023 · 5 comments
Open

Do we need to update 16kHz access in all notebooks to http #1

danellecline opened this issue Feb 6, 2023 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@danellecline
Copy link
Contributor

In the ListenUp notebook, the limit was getting hit for https access so it was switched to http.

Do we need to update all of the other notebooks that might hit this limit too?

@ryjombari will check the other notebooks as a start

@danellecline danellecline added the question Further information is requested label Feb 6, 2023
@carueda
Copy link
Member

carueda commented Feb 6, 2023

Just adding the specific link that was reported as failing:

https://pacific-sound-16khz.s3.amazonaws.com/2018/04/MARS-20180413T000000Z-16kHz.wav

@ryjombari
Copy link
Collaborator

ryjombari commented Feb 9, 2023

The humpback song detection notebook uses https for 16 kHz, however there is no problem because we load only the first 25 minutes.

@ryjombari
Copy link
Collaborator

ryjombari commented Feb 9, 2023

The 16 kHz example notebook also does not have a problem with loading 16 kHz data, but for a different reason: we copy the entire file to local storage before illustrating use of the data. However, there is one need for that notebook: change the 60 second resolution of the spectrogram to 5 seconds (this will fix the plotting that got jumbled).

@danellecline
Copy link
Contributor Author

@carueda did you happen to fix this? I'm happy to look at this, but I'm recalling you mentioned something about this on Slack. Just checking in.

@carueda
Copy link
Member

carueda commented Feb 23, 2023

@danellecline sorry if I was supposed to look into this! I think I mentioned that using https in general is a best practice, but that if AWS is just fine accepting http, then we could update the notebooks accordingly. I notice you did this one 93fb475 . Let me know and I can try updating the others (if so, what should I edit and where, I mean, in Colab, then download the notebook with output cells, then push the change, etc.?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants