Adding [[fallthrough]] attribute

Author: marzojr

actors.cc

@@ -3066,13 +3066,13 @@ int Actor::get_effective_prop(
 		if (get_flag(Obj_flags::paralyzed) || get_flag(Obj_flags::asleep) ||
 		        is_knocked_out())
 			return prop == Actor::dexterity ? 0 : 1;
-		// FALL THROUGH
+		[[fallthrough]];
 	case Actor::intelligence:
 		if (is_dead())
 			return prop == Actor::dexterity ? 0 : 1;
 		else if (get_flag(Obj_flags::charmed) || get_flag(Obj_flags::asleep))
 			val--;
-		// FALL THROUGH
+		[[fallthrough]];
 	case Actor::strength:
 		if (get_flag(Obj_flags::might))
 			val += (val < 15 ? val : 15);   // Add up to 15.

audio/midi_drivers/FMOplMidiDriver.cpp

@@ -298,7 +298,7 @@ void FMOplMidiDriver::send(uint32 b)
 	case 0x80:									/*note off */
 			// Quick hack, but we should never use it. since note offs will never be sent
 			b &= 0xFFFF;
-			// FALL THROUGH
+			[[fallthrough]];
 	case 0x90:{									/*note on */
 			auto note = static_cast<unsigned char>((b >> 8) & 0x7F);
 			auto vel = static_cast<unsigned char>((b >> 16) & 0x7F);

gamemgr/bggame.cc

@@ -1196,7 +1196,7 @@ bool Hand_Handler::draw_frame() {
 		if (currBackground != eSHOW_STATIC) {
 			break;
 		}
-		// FALL THROUGH
+		[[fallthrough]];
 	case eSHOW_STATIC:
 	case eNOP:
 		if (currOp == eSHOW_STATIC) {
@@ -1224,7 +1224,7 @@ bool Hand_Handler::draw_frame() {
 			currBackground = currOp;
 			break;
 		}
-		// FALL THROUGH
+		[[fallthrough]];
 	case eBLACK_SCREEN:
 		win->fill8(0, screenShape->get_width(), screenShape->get_height(),
 		           centerx + 12 - screenShape->get_width()/2,

gamemgr/modmgr.cc

@@ -408,7 +408,7 @@ ModManager::ModManager(const string &name, const string &menu, bool needtitle,
 			break;
 		default:
 			unknown_crc("Black Gate");
-			// FALLTHROUGH
+			[[fallthrough]];
 		case 0xafc35523:
 			// English BG
 			language = ENGLISH;
@@ -450,7 +450,7 @@ ModManager::ModManager(const string &name, const string &menu, bool needtitle,
 			break;
 		default:
 			unknown_crc("Serpent Isle");
-			// FALLTHROUGH
+			[[fallthrough]];
 		case 0xf98f5f3e:
 			// English SI
 			language = ENGLISH;

objs/egg.cc

@@ -764,7 +764,7 @@ bool Egg_object::is_active(
 #ifdef DEBUG
 		print_debug();
 #endif
-		// fall through
+		[[fallthrough]];
 	case party_near:        // Avatar or party member.
 		if (!obj->get_flag(Obj_flags::in_party))
 			return false;
@@ -1268,7 +1268,7 @@ bool Field_object::field_effect(
 		// Campfire (Fire in SI) doesn't hurt when burnt out
 		if (frame == 0)
 			return false;
-		// FALLTHROUGH
+		[[fallthrough]];
 	case fire_field:
 		actor->reduce_health(2 + rand() % 3, Weapon_data::fire_damage);
 		// But no sleeping here.

schedule.cc

@@ -1027,8 +1027,8 @@ void Patrol_schedule::now_what(
 		Game_object_vector nearby;
 		npc->find_nearby(nearby, PATH_SHAPE, 25, 0x10, c_any_qual, c_any_framenum);
 		gotpath = !nearby.empty();
+		[[fallthrough]];
 	}
-	// FALLTHROUGH
 	case 0: { // Find next path.
 		if (!gotpath) {
 			// SI seems to try switching to preprogrammed schedules
@@ -1122,7 +1122,7 @@ void Patrol_schedule::now_what(
 			case 25:        // 50% wrap to 0.
 				if (rand() % 2)
 					break;
-				// FALLTHROUGH
+				[[fallthrough]];
 			case 1:         // Wrap to 0.
 				pathnum = -1;
 				dir = 1;
@@ -1134,7 +1134,7 @@ void Patrol_schedule::now_what(
 			case 24:       // Read
 				// Find the book which will be read.
 				book = weak_from_obj(npc->find_closest(642, 4));
-				// FALLTHROUGH
+				[[fallthrough]];
 			case 3:         // Sit.
 				if (Sit_schedule::set_action(npc)) {
 					scr->start();   // Start next tick.
@@ -1840,7 +1840,7 @@ void Farmer_schedule::now_what(
 	switch (state) {
 	case start:
 		state = find_crop;
-		/* FALL THROUGH */
+		[[fallthrough]];
 	case find_crop: {
 		Game_object_vector crops;
 		crop = Game_object_weak();
@@ -2724,7 +2724,7 @@ void Desk_schedule::now_what(
 		}
 		state = sit_at_desk;
 		}
-		/* FALL THROUGH */
+		[[fallthrough]];
 	case sit_at_desk: {
 		const int frnum = npc->get_framenum();
 		// Not sitting?
@@ -3577,7 +3577,7 @@ void Waiter_schedule::now_what(
 		find_tables(964, 24);
 		find_prep_tables();
 		state = get_customer;
-		/* FALL THROUGH */
+		[[fallthrough]];
 	case get_customer:
 		if (!find_customer()) {
 			walk_to_prep();
@@ -3602,8 +3602,8 @@ void Waiter_schedule::now_what(
 			customers_ordered.push_back(customer);
 		}
 		state = took_order;
+		[[fallthrough]];
 	}
-	/* FALL THROUGH */
 	case took_order:
 		// Get up to 4 orders before serving them.
 		if (customers_ordered.size() >= 4 || customers.empty()) {
@@ -3659,8 +3659,8 @@ void Waiter_schedule::now_what(
 		Ready_food(npc);
 		cooking = false;
 		state = bring_food;
+		[[fallthrough]];
 	}
-		/* FALL THROUGH. */
 	case bring_food:
 		if (customers_ordered.empty()) {		// All done serving them?
 			if (rand() % 3 == 0)
@@ -3712,8 +3712,8 @@ void Waiter_schedule::now_what(
 			++items_in_hand;
 			break;
 		}
+		[[fallthrough]];
 	}
-		/* FALL THROUGH */
 	case picked_up_item:
 		set_current_item(nullptr);
 		if (cooking) {