diff --git a/src/sdg/producten/management/commands/send_email_to_users_about_doordrukken.py b/src/sdg/producten/management/commands/send_email_to_users_about_doordrukken.py index 165bfdcec..0c178728b 100644 --- a/src/sdg/producten/management/commands/send_email_to_users_about_doordrukken.py +++ b/src/sdg/producten/management/commands/send_email_to_users_about_doordrukken.py @@ -71,6 +71,7 @@ def create_and_send_mail( ).url, "org_type_name": cfg.name, "lokale_overheid": lokale_overheid, + "doordruk_date": settings.SDG_PRESS_THROUGH_DAYS, } html_message = render_to_string( @@ -79,7 +80,7 @@ def create_and_send_mail( ) send_mail( - f"{settings.SDG_PRESS_THROUGH_DAYS} dagen tot een product in SDG automatisch zal worden gepubliceerd.", + f"{settings.SDG_PRESS_THROUGH_DAYS} dagen tot een SDG-producttekst automatisch wordt gepubliceerd", strip_tags(html_message), settings.DEFAULT_FROM_EMAIL, [user.email], diff --git a/src/sdg/producten/management/commands/send_monthly_broken_links_report.py b/src/sdg/producten/management/commands/send_monthly_broken_links_report.py index ee8d2a0d7..f7b2e3673 100644 --- a/src/sdg/producten/management/commands/send_monthly_broken_links_report.py +++ b/src/sdg/producten/management/commands/send_monthly_broken_links_report.py @@ -35,7 +35,9 @@ def construct_base_url( path=url_path, ) - def create_and_send_mail(self, user, broken_links, multiple_organizations: bool): + def create_and_send_mail( + self, user, broken_links, multiple_organizations: bool, user_organizations + ): def sort_compare_fn(broken_link): return ( broken_link.product.catalogus.lokale_overheid.__str__(), @@ -43,12 +45,16 @@ def sort_compare_fn(broken_link): broken_link.occurring_field, ) + org_type_name = org_type_cfg().name + mail_context = { "user_full_name": user.get_full_name(), "broken_links": sorted(broken_links, key=sort_compare_fn), "sender_organization": org_type_cfg().organisation_name, + "org_type_name": org_type_name, "multiple_organizations": multiple_organizations, "base_url": self.construct_base_url(), + "user_organizations": user_organizations, } html_message = render_to_string( @@ -57,7 +63,7 @@ def sort_compare_fn(broken_link): ) send_mail( - "Rapportage foutieve links in SDG-invoervoorziening", + f"Foute links in SDG-{org_type_name.lower()}teksten", strip_tags(html_message), settings.DEFAULT_FROM_EMAIL, [user.email], @@ -79,7 +85,6 @@ def handle(self, *args, **options): lokale_overheid: LokaleOverheid = ( broken_link.product.catalogus.lokale_overheid ) - organization_id = lokale_overheid.organisatie_id roles: Role = lokale_overheid.roles receiver_roles: Role = ( @@ -94,7 +99,7 @@ def handle(self, *args, **options): broken_links, user_organizations, user = grouped_users[ receiver_role.user.email ] - user_organizations.add(organization_id) + user_organizations.add(lokale_overheid.organisatie) broken_links.append(broken_link) # Update user grouped_users[receiver_role.user.email] = ( @@ -110,4 +115,5 @@ def handle(self, *args, **options): user=user, broken_links=broken_links, multiple_organizations=multiple_organizations, + user_organizations=user_organizations, ) diff --git a/src/sdg/templates/producten/_include/doordruk_warning.html b/src/sdg/templates/producten/_include/doordruk_warning.html index 347df4ac1..7601c1f90 100644 --- a/src/sdg/templates/producten/_include/doordruk_warning.html +++ b/src/sdg/templates/producten/_include/doordruk_warning.html @@ -4,7 +4,7 @@ {% if doordruk_activation_warning == True %}
- Bij het controleren van de links in de specifieke gegevens van - producten, waar jij redacteur of beheerder van bent, zijn er fouten - opgetreden. Het gaat om de volgende link(s): + Bij het controleren van de teksten van de {{ org_type_name }} {{ user_organizations|join:", " }} + hebben we een paar foute links ontdekt. + Bij het aanklikken van deze link krijg je een foutmelding. De links + staan in een producttekst waar jij redacteur of beheerder van bent. Het + gaat om de volgende link(s):