Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Als recordmanager wil ik de naam van een vernietigingslijst kunnen bewerken zodat ik foutjes ongedaan kan maken #560

Closed
1 of 2 tasks
svenvandescheur opened this issue Dec 17, 2024 · 2 comments
Closed
1 of 2 tasks

Als recordmanager wil ik de naam van een vernietigingslijst kunnen bewerken zodat ik foutjes ongedaan kan maken #560

svenvandescheur opened this issue Dec 17, 2024 · 2 comments
Assignees
@Xaohs

Comments

@svenvandescheur
Copy link
Contributor

svenvandescheur commented Dec 17, 2024 •
edited
Loading

  • backend
  • frontend
@svenvandescheur svenvandescheur converted this from a draft issue Dec 17, 2024
@svenvandescheur
Copy link
Contributor Author

https://dimpact.atlassian.net/jira/software/c/projects/PZ/boards/258?selectedIssue=PZ-4031&sprintStarted=true

@SilviaAmAm
Copy link
Collaborator

This is already possible:

open-archiefbeheer/backend/src/openarchiefbeheer/destruction/api/serializers.py

Line 409 in 35d14f0

instance.name = validated_data.pop("name", instance.name)

And it is only possible for a record_manager AND if the list is in status "new":

open-archiefbeheer/backend/src/openarchiefbeheer/destruction/api/permissions.py

Line 40 in 35d14f0

def has_permission(self, request, view):

@Xaohs Xaohs self-assigned this Dec 24, 2024
@Xaohs Xaohs moved this from Todo to In Progress in Open Archiefbeheer - Sprints Dec 24, 2024
Xaohs pushed a commit that referenced this issue Dec 24, 2024
✨ #560 - feat: renaming the name of a destruction list
aff01e1
svenvandescheur added a commit that referenced this issue Jan 2, 2025
@svenvandescheur
✅ #560 - test: attempt to fix the tests
1e7b0ed
svenvandescheur added a commit that referenced this issue Jan 2, 2025
@svenvandescheur
🚚 #560 - test: move test file from issues to features
babe8a6
svenvandescheur added a commit that referenced this issue Jan 2, 2025
@svenvandescheur
🚚 #560 - test: move test file from issues to features
d76f28d
svenvandescheur pushed a commit that referenced this issue Jan 2, 2025
@svenvandescheur
✨ #560 - feat: renaming the name of a destruction list
9c3ffec
svenvandescheur added a commit that referenced this issue Jan 2, 2025
@svenvandescheur
✅ #560 - test: attempt to fix the tests
2ac0ae3
svenvandescheur added a commit that referenced this issue Jan 2, 2025
@svenvandescheur
🚚 #560 - test: move test file from issues to features
ca39b9b
@svenvandescheur svenvandescheur moved this from In Progress to Done in Open Archiefbeheer - Sprints Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xaohs Xaohs

Labels
None yet
Projects
Open Archiefbeheer - Sprints
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@svenvandescheur @SilviaAmAm @Xaohs