Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects API: ensure mandatory fields aren't required for a HTTP PATCH call #519

Closed
alextreme opened this issue Jan 13, 2025 · 2 comments
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request owner: utrecht triage

Comments

@alextreme
Copy link
Member

Thema / Theme

Objecten API

Omschrijving / Description

Taiga Utrecht 325

Mandatory fields in the 'data' of an object are required when sending a HTTP PATCH request, even though that data isn't changed.

Taiga issue has a clear example based on https://github.com/open-objecten/objecttypes/blob/main/community-concepts/Medewerker/medewerker-schema.json which shows that the following fields needs to be sent in when doing a PATCH.

I'm not sure if this classifies as a bug or not, the PATCH RFC leaves this rather open in my eyes but I do agree that it's not how I would expect PATCH to behave

image

Toegevoegde waarde / Added value

No response

Aanvullende opmerkingen / Additional context

No response

@alextreme
Copy link
Member Author

Anna mentioned that this may have been fixed recently after a comment from Sidney

@danielmursa-dev
Copy link
Contributor

@alextreme, checked, this problem seems already solved in this PR #469
In specific this test passes

def test_patch_validates_merged_object_rather_than_partial_object(self, m):
where it make a PATCH request with a field that is not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request owner: utrecht triage
Projects
Status: Done
Development

No branches or pull requests

2 participants