Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary variables from the helper files #62

Open
SilviaAmAm opened this issue Jun 30, 2023 · 0 comments
Open

Remove unnecessary variables from the helper files #62

SilviaAmAm opened this issue Jun 30, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@SilviaAmAm
Copy link
Collaborator

Not all charts need these vars:

{{/*
Worker labels
*/}}
{{- define "<name>.workerLabels" -}}
{{ include "<name>.commonLabels" . }}
{{ include "<name>.workerSelectorLabels" . }}
{{- end }}

{{/*
Worker selector labels
*/}}
{{- define "<name>.workerSelectorLabels" -}}
app.kubernetes.io/name: {{ include "<name>.workerName" . }}
{{- end }}

We should check from which charts it can be removed.

@SilviaAmAm SilviaAmAm added the enhancement New feature or request label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant