Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the probes to empty dicts breaks the indentation #119

Open
SilviaAmAm opened this issue Jul 8, 2024 · 1 comment · May be fixed by #161
Open

Setting the probes to empty dicts breaks the indentation #119

SilviaAmAm opened this issue Jul 8, 2024 · 1 comment · May be fixed by #161
Assignees
@SilviaAmAm
Labels
bug Something isn't working

Comments

@SilviaAmAm
Copy link
Collaborator

In openarchiefbeheer, setting these fields in the values.yaml:

livenessProbe: {}
readinessProbe: {}

results in

charts/charts/openarchiefbeheer$ helm lint .
==> Linting .
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 56: did not find expected key

Error: 1 chart(s) linted, 1 chart(s) failed

While setting the probes to:

livenessProbe:
  initialDelaySeconds: 60
  periodSeconds: 10
  timeoutSeconds: 5
  failureThreshold: 6
  successThreshold: 1

readinessProbe:
  initialDelaySeconds: 30
  periodSeconds: 10
  timeoutSeconds: 5
  failureThreshold: 6
  successThreshold: 1

Results in a chart without errors when running helm lint.

We need to find a way to disable the probes without breaking the chart.
@SilviaAmAm SilviaAmAm added the bug Something isn't working label Jul 8, 2024
@sjoerdie
Copy link
Collaborator

Example: https://github.com/bitnami/charts/blob/main/bitnami/grafana/templates/deployment.yaml

SilviaAmAm added a commit that referenced this issue Dec 27, 2024
@SilviaAmAm
✨ [#119] Follow grafana example to disable liveness probe
e2c0722 
For now just for OAB, if it works well, I will do it also for the other
charts. I removed the readinessProbe value because it was not being
used.
@SilviaAmAm SilviaAmAm moved this to Has Pull Request in Open Archiefbeheer - Sprints Dec 27, 2024
@SilviaAmAm SilviaAmAm linked a pull request Dec 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilviaAmAm SilviaAmAm

Labels
bug Something isn't working
Projects
Open Archiefbeheer - Sprints
Status: Has Pull Request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#119] Disabling liveness probes maykinmedia/charts
2 participants
@SilviaAmAm @sjoerdie